Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2257123002:
Add a timeout for starting the camera on CameraCapturer. (Closed)
|
Created:
4 years, 4 months ago by sakal Modified:
4 years, 4 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd a timeout for starting the camera on CameraCapturer.
This allows to at least get a camera error back if the camera thread freezes. Application can use this as a signal to restart the program.
R=magjed@webrtc.org
Committed: https://crrev.com/294fb050a0ac5c3bbb660bd831b445aedcc3ece1
Cr-Commit-Position: refs/heads/master@{#13830}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 15 (6 generated)
PTAL
Description was changed from ========== Add a timeout for starting the camera on CameraCapturer. R=magjed@webrtc.org ========== to ========== Add a timeout for starting the camera on CameraCapturer. This allows to at least get a camera error back if the camera thread freezes. Application can use this as a signal to restart the program. R=magjed@webrtc.org ==========
https://codereview.webrtc.org/2257123002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/CameraCapturer.java (right): https://codereview.webrtc.org/2257123002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/CameraCapturer.java:179: uiThreadHandler.postDelayed(openCameraTimeoutRunnable, delayMs + OPEN_CAMERA_TIMEOUT); Maybe post it inside the runnable below together with the call to createCameraSession?
https://codereview.webrtc.org/2257123002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/CameraCapturer.java (right): https://codereview.webrtc.org/2257123002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/CameraCapturer.java:179: uiThreadHandler.postDelayed(openCameraTimeoutRunnable, delayMs + OPEN_CAMERA_TIMEOUT); On 2016/08/18 13:46:36, magjed_webrtc wrote: > Maybe post it inside the runnable below together with the call to > createCameraSession? That would break the purpose of this CL. If the camera thread is blocked, this would never get posted.
lgtm https://codereview.webrtc.org/2257123002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/CameraCapturer.java (right): https://codereview.webrtc.org/2257123002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/CameraCapturer.java:179: uiThreadHandler.postDelayed(openCameraTimeoutRunnable, delayMs + OPEN_CAMERA_TIMEOUT); On 2016/08/18 13:48:17, sakal wrote: > On 2016/08/18 13:46:36, magjed_webrtc wrote: > > Maybe post it inside the runnable below together with the call to > > createCameraSession? > > That would break the purpose of this CL. If the camera thread is blocked, this > would never get posted. Ah, right :)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Add a timeout for starting the camera on CameraCapturer. This allows to at least get a camera error back if the camera thread freezes. Application can use this as a signal to restart the program. R=magjed@webrtc.org ========== to ========== Add a timeout for starting the camera on CameraCapturer. This allows to at least get a camera error back if the camera thread freezes. Application can use this as a signal to restart the program. R=magjed@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add a timeout for starting the camera on CameraCapturer. This allows to at least get a camera error back if the camera thread freezes. Application can use this as a signal to restart the program. R=magjed@webrtc.org ========== to ========== Add a timeout for starting the camera on CameraCapturer. This allows to at least get a camera error back if the camera thread freezes. Application can use this as a signal to restart the program. R=magjed@webrtc.org Committed: https://crrev.com/294fb050a0ac5c3bbb660bd831b445aedcc3ece1 Cr-Commit-Position: refs/heads/master@{#13830} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/294fb050a0ac5c3bbb660bd831b445aedcc3ece1 Cr-Commit-Position: refs/heads/master@{#13830} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
