Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2257083002: Reland of StartTimestamp generated randomly in RtpSender constructor (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
terelius, åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, mflodman, philipel
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of StartTimestamp generated randomly in RtpSender constructor (patchset #1 id:1 of https://codereview.webrtc.org/2248413002/ ) Reason for revert: Reland: downstream code expectation about rtp_sender timestamp adjusted. Original issue's description: > Revert of StartTimestamp generated randomly in RtpSender constructor (patchset #4 id:60001 of https://codereview.webrtc.org/2241193002/ ) > > Reason for revert: > Breaks downstream code. > > Original issue's description: > > StartTimestamp generated randomly in RtpSender constructor > > instead of not-randomly at SetSendingState(true) > > Renamed to timestamp_offset_ to better match meaning of the variable. > > > > R=asapersson@webrtc.org, terelius@webrtc.org > > > > Committed: https://crrev.com/4466782ae43e1b1125a55ee7e18abd10dd37cede > > Cr-Commit-Position: refs/heads/master@{#13796} > > TBR=asapersson@webrtc.org,terelius@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/86c96948e340cf8b879bddb0c7293f3b5ad4dad4 > Cr-Commit-Position: refs/heads/master@{#13798} TBR=asapersson@webrtc.org,terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/71fead2146b6895d4d04c3f4c2a8eb465b2c5881 Cr-Commit-Position: refs/heads/master@{#13811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -49 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 8 chunks +15 lines, -27 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danilchap
Created Reland of StartTimestamp generated randomly in RtpSender constructor
4 years, 4 months ago (2016-08-18 09:01:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2257083002/1
4 years, 4 months ago (2016-08-18 09:01:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 09:01:52 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 09:02:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71fead2146b6895d4d04c3f4c2a8eb465b2c5881
Cr-Commit-Position: refs/heads/master@{#13811}

Powered by Google App Engine
This is Rietveld 408576698