Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2256743002: Add playout_delay_oracle_unittest as gn target (Closed)

Created:
4 years, 4 months ago by Irfan
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add playout_delay_oracle_unittest as gn target BUG= Committed: https://crrev.com/8df4d0e426a059892f32e8696ebc5946f4b6be45 Cr-Commit-Position: refs/heads/master@{#13821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Irfan
PTAL
4 years, 4 months ago (2016-08-17 16:42:21 UTC) #3
kjellander_webrtc
Thanks. Please use https://codereview.webrtc.org for WebRTC reviews (or the links gets created with codereview.chromium.org host, ...
4 years, 4 months ago (2016-08-17 16:51:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2256743002/1
4 years, 4 months ago (2016-08-17 17:09:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7502)
4 years, 4 months ago (2016-08-17 17:19:05 UTC) #8
Irfan
Stefan, need OWNER lgtm, thx
4 years, 4 months ago (2016-08-17 17:39:24 UTC) #10
stefan-webrtc
lgtm
4 years, 4 months ago (2016-08-18 13:20:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2256743002/1
4 years, 4 months ago (2016-08-18 13:20:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:53:40 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:53:50 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8df4d0e426a059892f32e8696ebc5946f4b6be45
Cr-Commit-Position: refs/heads/master@{#13821}

Powered by Google App Engine
This is Rietveld 408576698