Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h

Issue 2255203002: iLBC: Handle a case of bad input data (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
diff --git a/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h b/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
index 67f05a57688b37cb114af509a5425aa6c985f392..4ea51f28175144fc122ab7e525f9a485d56abcc4 100644
--- a/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
+++ b/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
@@ -25,14 +25,15 @@
* frame residual decoder function (subrutine to iLBC_decode)
*---------------------------------------------------------------*/
-void WebRtcIlbcfix_DecodeResidual(
- IlbcDecoder *iLBCdec_inst,
- /* (i/o) the decoder state structure */
- iLBC_bits *iLBC_encbits, /* (i/o) Encoded bits, which are used
- for the decoding */
- int16_t *decresidual, /* (o) decoded residual frame */
- int16_t *syntdenum /* (i) the decoded synthesis filter
- coefficients */
- );
+// Returns true on success, false on failure. In case of failure, the decoder
hlundin-webrtc 2016/08/23 07:55:26 Again, true, false and int...
+// state may be corrupted and needs resetting.
+int WebRtcIlbcfix_DecodeResidual(
+ IlbcDecoder* iLBCdec_inst, /* (i/o) the decoder state structure */
+ iLBC_bits* iLBC_encbits, /* (i/o) Encoded bits, which are used
+ for the decoding */
+ int16_t* decresidual, /* (o) decoded residual frame */
+ int16_t* syntdenum /* (i) the decoded synthesis filter
+ coefficients */
+ ) WARN_UNUSED_RESULT;
#endif

Powered by Google App Engine
This is Rietveld 408576698