Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2255173002: Remove audio_device_test_func. (Closed)

Created:
4 years, 4 months ago by Max Morin WebRTC
Modified:
4 years, 4 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove audio_device_test_func. This code does not work and hasn't been used in a long time. It also lacks a GN target. There's no reason to save it. BUG=none Committed: https://crrev.com/3a11933a63ff25e7f94c1f9760ecfb65474de22c Cr-Commit-Position: refs/heads/master@{#13820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3187 lines) Patch
M webrtc/modules/audio_device/audio_device.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/modules/audio_device/test/README.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/modules/audio_device/test/audio_device_test_func.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D webrtc/modules/audio_device/test/func_test_manager.h View 1 chunk +0 lines, -233 lines 0 comments Download
D webrtc/modules/audio_device/test/func_test_manager.cc View 1 chunk +0 lines, -2751 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Max Morin WebRTC
Henrik: PTAL
4 years, 4 months ago (2016-08-18 12:48:39 UTC) #3
henrika_webrtc
LGTM. Thanks for fixing!
4 years, 4 months ago (2016-08-18 12:52:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2255173002/1
4 years, 4 months ago (2016-08-18 12:55:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:20:44 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:20:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a11933a63ff25e7f94c1f9760ecfb65474de22c
Cr-Commit-Position: refs/heads/master@{#13820}

Powered by Google App Engine
This is Rietveld 408576698