Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2255093002:
Added missing level controller unittest to the modules/BUILD.gn build file (Closed)
|
Created:
4 years, 4 months ago by peah-webrtc Modified:
4 years, 4 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded missing unittest to the modules/BUILD.gn build file
NOTRY=True
BUG=
Committed: https://crrev.com/e9a6acfbf5e275822ea7c900c5317bd4869c1c05
Cr-Commit-Position: refs/heads/master@{#13813}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
peah@webrtc.org changed reviewers: + kjellander@webrtc.org
One of the level controller unittests had not been added to the BUILD.gn file for the modules_unittests binary. This CL adds that test to that file.
lgtm, feel free to land with NOTRY=True if the trybots I fired are green.
Description was changed from ========== Added missing unittest to the modules/BUILD.gn build file BUG= ========== to ========== Added missing unittest to the modules/BUILD.gn build file NOTRY=True BUG= ==========
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7514)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7518)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Added missing unittest to the modules/BUILD.gn build file NOTRY=True BUG= ========== to ========== Added missing unittest to the modules/BUILD.gn build file NOTRY=True BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Added missing unittest to the modules/BUILD.gn build file NOTRY=True BUG= ========== to ========== Added missing unittest to the modules/BUILD.gn build file NOTRY=True BUG= Committed: https://crrev.com/e9a6acfbf5e275822ea7c900c5317bd4869c1c05 Cr-Commit-Position: refs/heads/master@{#13813} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e9a6acfbf5e275822ea7c900c5317bd4869c1c05 Cr-Commit-Position: refs/heads/master@{#13813} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
