webrtc/modules/congestion_controller/probe_bitrate_estimator.h - Issue 2254733005: Only use payload size within the receive/send interval for bitrate probing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/probe_bitrate_estimator.h

Issue 2254733005: Only use payload size within the receive/send interval for bitrate probing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/probe_bitrate_estimator.cc » ('j') | webrtc/modules/congestion_controller/probe_bitrate_estimator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/probe_bitrate_estimator.h

diff --git a/webrtc/modules/congestion_controller/probe_bitrate_estimator.h b/webrtc/modules/congestion_controller/probe_bitrate_estimator.h

index 7f0c4569c97f039976e822d94887987d66e8e994..4d58b509407d0545998a55938abcf06f697ee647 100644

--- a/webrtc/modules/congestion_controller/probe_bitrate_estimator.h

+++ b/webrtc/modules/congestion_controller/probe_bitrate_estimator.h

@@ -11,8 +11,9 @@

#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_PROBE_BITRATE_ESTIMATOR_H_

#define WEBRTC_MODULES_CONGESTION_CONTROLLER_PROBE_BITRATE_ESTIMATOR_H_

-#include <map>

#include <limits>

+#include <map>

+#include <set>

#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"

@@ -40,7 +41,7 @@ class ProbeBitrateEstimator {

private:

struct AggregatedCluster {

- int num_probes = 0;

+ std::set<uint16_t> sequence_numbers;

int64_t first_send_ms = std::numeric_limits<int64_t>::max();

int64_t last_send_ms = 0;

int64_t first_receive_ms = std::numeric_limits<int64_t>::max();