Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc

Issue 2254733005: Only use payload size within the receive/send interval for bitrate probing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Keep track of the size of the last/first sent/receive packet. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 AddPacketFeedback(1, 1000, 70, 84); 118 AddPacketFeedback(1, 1000, 70, 84);
119 AddPacketFeedback(1, 1000, 75, 90); 119 AddPacketFeedback(1, 1000, 75, 90);
120 120
121 CheckResult(0, 1200000, 10, 90); 121 CheckResult(0, 1200000, 10, 90);
122 122
123 AddPacketFeedback(0, 1000, 40, 60); 123 AddPacketFeedback(0, 1000, 40, 60);
124 124
125 EXPECT_EQ(1ul, results_.size()); 125 EXPECT_EQ(1ul, results_.size());
126 } 126 }
127 127
128 TEST_F(TestProbeBitrateEstimator, IgnoreSizeLastSendPacket) {
129 AddPacketFeedback(0, 1000, 0, 10);
130 AddPacketFeedback(0, 1000, 10, 20);
131 AddPacketFeedback(0, 1000, 20, 30);
132 AddPacketFeedback(0, 1000, 30, 40);
133 AddPacketFeedback(0, 1500, 40, 50);
danilchap 2016/08/22 13:53:35 May be add note that increased packet size increas
philipel 2016/08/22 14:06:40 Acknowledged.
134
135 CheckResult(0, 800000, 10, 40);
danilchap 2016/08/22 13:53:35 May be add a note that 1st CheckResult check bitra
philipel 2016/08/22 14:06:40 Acknowledged.
136 CheckResult(1, 800000, 10, 50);
137 }
138
139 TEST_F(TestProbeBitrateEstimator, IgnoreSizeFirstReceivePacket) {
140 AddPacketFeedback(0, 1500, 0, 10);
141 AddPacketFeedback(0, 1000, 10, 20);
142 AddPacketFeedback(0, 1000, 20, 30);
143 AddPacketFeedback(0, 1000, 30, 40);
144 AddPacketFeedback(0, 1000, 40, 50);
145
146 CheckResult(0, 800000, 10, 40);
danilchap 2016/08/22 13:53:35 does it make sense to CheckResult twice in this te
philipel 2016/08/22 14:06:40 Copy-paste ftw :) But no, it doesn't.
147 CheckResult(1, 800000, 10, 50);
148 }
149
128 } // namespace webrtc 150 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698