Issue 2254143003: GYP is not validating flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2254143003: GYP is not validating flags. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc

Modified:
4 years, 4 months ago

Reviewers:
kjellander_webrtc

CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

GYP is not validating flags in neteq_quality_test.cc All the validation functions are dead code. BUG=

Patch Set 1 #

Patch Set 2 : Dead code. #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -41 lines)			Patch
	M	webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc	View	1	8 chunks	+2 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kjellander_webrtc

4 years, 4 months ago (2016-08-19 07:20:27 UTC) #4

I think the validators are actually working but that the code is not executed
unless a flag is passed. Not until then there's something to validate.

The case with this code is that it (as part of "neteq_test_support" target) is
shared between multiple test/tool binaries:
https://cs.chromium.org/search/?q=:neteq_test_support+f:gn&sq=package:chromiu...

Only some of them uses the --in_filename and other flags. More importantly:
modules_unittests doesn't.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages