webrtc/media/sctp/sctpdataengine_unittest.cc - Issue 2254003002: Fixing off-by-one error with max SCTP id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/sctp/sctpdataengine_unittest.cc

Issue 2254003002: Fixing off-by-one error with max SCTP id. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Removing unneeded parentheses. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/sctp/sctpdataengine_unittest.cc

diff --git a/webrtc/media/sctp/sctpdataengine_unittest.cc b/webrtc/media/sctp/sctpdataengine_unittest.cc

index 51eb27a4166056c3152a8f34c45ed39bbd1a4f5c..4b8be17e9c4dee2a4bcc41c8c6313c57851b707d 100644

--- a/webrtc/media/sctp/sctpdataengine_unittest.cc

+++ b/webrtc/media/sctp/sctpdataengine_unittest.cc

@@ -490,8 +490,8 @@ TEST_F(SctpDataMediaChannelTest, EngineSignalsRightChannel) {

TEST_F(SctpDataMediaChannelTest, RefusesHighNumberedChannels) {

SetupConnectedChannels();

- EXPECT_TRUE(AddStream(1022));

- EXPECT_FALSE(AddStream(1023));

+ EXPECT_TRUE(AddStream(kMaxSctpStreams - 1));

+ EXPECT_FALSE(AddStream(kMaxSctpStreams));

}

// Flaky, see webrtc:4453.