Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/api/peerconnectioninterface_unittest.cc

Issue 2254003002: Fixing off-by-one error with max SCTP id. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removing unneeded parentheses. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/datachannel.cc ('K') | « webrtc/api/datachannel.cc ('k') | webrtc/api/webrtcsdp.cc » ('j') | webrtc/media/sctp/sctpdataengine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface_unittest.cc
diff --git a/webrtc/api/peerconnectioninterface_unittest.cc b/webrtc/api/peerconnectioninterface_unittest.cc
index 0b24fcb7cfc4d119af78dacd4258d84f6188aa76..85b3649a2df521172ce4769e7d8abcbfae8aa8d3 100644
--- a/webrtc/api/peerconnectioninterface_unittest.cc
+++ b/webrtc/api/peerconnectioninterface_unittest.cc
@@ -1827,12 +1827,12 @@ TEST_F(PeerConnectionInterfaceTest,
channel = pc_->CreateDataChannel("x", &config);
EXPECT_TRUE(channel == NULL);
- config.id = cricket::kMaxSctpSid;
+ config.id = cricket::kMaxSctpStreams - 1;
channel = pc_->CreateDataChannel("max", &config);
EXPECT_TRUE(channel != NULL);
EXPECT_EQ(config.id, channel->id());
- config.id = cricket::kMaxSctpSid + 1;
+ config.id = cricket::kMaxSctpStreams;
channel = pc_->CreateDataChannel("x", &config);
EXPECT_TRUE(channel == NULL);
}
« webrtc/api/datachannel.cc ('K') | « webrtc/api/datachannel.cc ('k') | webrtc/api/webrtcsdp.cc » ('j') | webrtc/media/sctp/sctpdataengine.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698