Method to parse event log directly from a string.

Method to parse event log directly from a string.

Switches the main parsing function for RtcEventLogs to take an istream instead of a file pointer. Adds wrappers that accept either a string or a filename.

Committed: https://crrev.com/8c16520949ab0b3d3f2e51bb40278f9ca64659fd
Cr-Commit-Position: refs/heads/master@{#13852}

[terelius, 2016-08-19 14:31:15]

terelius@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-08-22 07:30:05]

lgtm with a nit

https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_parser.cc (right):

https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_parser.cc:139: }
This can be moved to before the while loop since you already check for eof at
line 166

[terelius, 2016-08-22 14:48:52]

https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_parser.cc (right):

https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_parser.cc:139: }
On 2016/08/22 07:30:05, stefan-webrtc (holmer) wrote:
> This can be moved to before the while loop since you already check for eof at
> line 166

I think it has to be here; EOF is not set until you attempt to read the next
character. Checking for EOF at line 166 might be redundant however.

[stefan-webrtc, 2016-08-22 14:54:57]

https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
File webrtc/call/rtc_event_log_parser.cc (right):

https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
webrtc/call/rtc_event_log_parser.cc:139: }
On 2016/08/22 14:48:52, terelius wrote:
> On 2016/08/22 07:30:05, stefan-webrtc (holmer) wrote:
> > This can be moved to before the while loop since you already check for eof
at
> > line 166
> 
> I think it has to be here; EOF is not set until you attempt to read the next
> character. Checking for EOF at line 166 might be redundant however.

Yes, one of them should be possible to remove.

[terelius, 2016-08-22 15:34:55]

On 2016/08/22 14:54:57, stefan-webrtc (holmer) wrote:
>
https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
> File webrtc/call/rtc_event_log_parser.cc (right):
> 
>
https://codereview.webrtc.org/2253943006/diff/20001/webrtc/call/rtc_event_log...
> webrtc/call/rtc_event_log_parser.cc:139: }
> On 2016/08/22 14:48:52, terelius wrote:
> > On 2016/08/22 07:30:05, stefan-webrtc (holmer) wrote:
> > > This can be moved to before the while loop since you already check for eof
> at
> > > line 166
> > 
> > I think it has to be here; EOF is not set until you attempt to read the next
> > character. Checking for EOF at line 166 might be redundant however.
> 
> Yes, one of them should be possible to remove.

The two eof checks do completely different things and are not interchangeable.
What I meant is that checking gcount on line 166 will implicitly detect eof.

[terelius, 2016-08-22 16:02:40]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 16:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2016-08-22 17:27:34]

The CQ bit was unchecked by terelius@webrtc.org

[terelius, 2016-08-22 17:27:55]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2016-08-22 17:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2253943006/#ps40001 (title:
"Dont check for eof if checking bytes read anyway.")

[commit-bot: I haz the power, 2016-08-22 17:28:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-22 18:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 18:03:15]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[terelius, 2016-08-22 18:23:02]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2016-08-22 18:30:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-22 18:35:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 18:35:59]

Description was changed from

==========
Method to parse event log directly from a string.

Switches the main parsing function for RtcEventLogs to take an istream instead
of a file pointer. Adds wrappers that accept either a string or a filename.
==========

to

==========
Method to parse event log directly from a string.

Switches the main parsing function for RtcEventLogs to take an istream instead
of a file pointer. Adds wrappers that accept either a string or a filename.

Committed: https://crrev.com/8c16520949ab0b3d3f2e51bb40278f9ca64659fd
Cr-Commit-Position: refs/heads/master@{#13852}
==========

[commit-bot: I haz the power, 2016-08-22 18:36:00]

Patchset 3 (id:??) landed as
https://crrev.com/8c16520949ab0b3d3f2e51bb40278f9ca64659fd
Cr-Commit-Position: refs/heads/master@{#13852}