Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2253763002: Close input file in FileAudioDevice::StopRecording. (Closed)

Created:
4 years, 4 months ago by noahric
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Close input file in FileAudioDevice::StopRecording. Also added some more logging, to help track down start/stop, start failure, and the name of the file used. BUG= Committed: https://crrev.com/d8a72f0ab24f7b6df63a3d0448b170c03c26aa48 Cr-Commit-Position: refs/heads/master@{#13802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 7 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
noahric
4 years, 4 months ago (2016-08-16 23:08:40 UTC) #2
noahric
4 years, 4 months ago (2016-08-16 23:53:30 UTC) #4
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-17 05:57:41 UTC) #5
henrika_webrtc
LGTM
4 years, 4 months ago (2016-08-17 08:08:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2253763002/1
4 years, 4 months ago (2016-08-17 21:58:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 22:14:52 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 22:15:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8a72f0ab24f7b6df63a3d0448b170c03c26aa48
Cr-Commit-Position: refs/heads/master@{#13802}

Powered by Google App Engine
This is Rietveld 408576698