Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc

Issue 2253153004: Updated mixer unittests and fixed a related bug in the new mixer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove_comments_add_level_indicator_dep
Patch Set: Rebase from upstream. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc
diff --git a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc
index 72f8e151848b1c9be6035b3a76631bf017014212..96ce8ce41723b59dd072a22b3d565861adb4acbf 100644
--- a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc
+++ b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc
@@ -187,7 +187,6 @@ void NewAudioConferenceMixerImpl::Mix(int sample_rate,
size_t number_of_channels,
AudioFrame* audio_frame_for_mixing) {
RTC_DCHECK(number_of_channels == 1 || number_of_channels == 2);
- size_t remainingAudioSourcesAllowedToMix = kMaximumAmountOfMixedAudioSources;
RTC_DCHECK(thread_checker_.CalledOnValidThread());
AudioFrameList mixList;
AudioFrameList additionalFramesList;
@@ -218,8 +217,7 @@ void NewAudioConferenceMixerImpl::Mix(int sample_rate,
SetOutputFrequency(mixing_frequency);
}
- mixList = UpdateToMix(remainingAudioSourcesAllowedToMix);
- remainingAudioSourcesAllowedToMix -= mixList.size();
+ mixList = UpdateToMix(kMaximumAmountOfMixedAudioSources);
GetAdditionalAudio(&additionalFramesList);
}
@@ -526,15 +524,6 @@ int32_t NewAudioConferenceMixerImpl::MixFromList(
for (AudioFrameList::const_iterator iter = audioFrameList.begin();
iter != audioFrameList.end(); ++iter) {
- if (position >= kMaximumAmountOfMixedAudioSources) {
- WEBRTC_TRACE(
- kTraceMemory, kTraceAudioMixerServer, id,
- "Trying to mix more than max amount of mixed audio sources:%d!",
- kMaximumAmountOfMixedAudioSources);
- // Assert and avoid crash
- RTC_NOTREACHED();
- position = 0;
- }
if (!iter->muted) {
MixFrames(mixedAudio, iter->frame, use_limiter);
}
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698