webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m - Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m

Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changes in response to reviewer comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/examples/objc/AppRTCDemo/ios/ARDMainView.h ('K') | « webrtc/examples/objc/AppRTCDemo/ios/ARDMainView.m ('k') | webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.h » ('j') | webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m

diff --git a/webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m b/webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m

index a684ba32b06a94e987a8d10b12bce257f1272384..80eafbc142886bedeecef7a482dfd0e72b675d84 100644

--- a/webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m

+++ b/webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m

@@ -57,6 +57,7 @@

didInputRoom:(NSString *)room

isLoopback:(BOOL)isLoopback

isAudioOnly:(BOOL)isAudioOnly

+ shouldMakeAecDump:(BOOL)shouldMakeAecDump

tkchin_webrtc 2016/08/24 00:42:20 nit: align

peah-webrtc 2016/08/25 09:25:08 Done.

useManualAudio:(BOOL)useManualAudio {

if (!room.length) {

[self showAlertWithMessage:@"Missing room name."];

@@ -96,6 +97,7 @@

[[ARDVideoCallViewController alloc] initForRoom:trimmedRoom

isLoopback:isLoopback

isAudioOnly:isAudioOnly

+ shouldMakeAecDump:shouldMakeAecDump

tkchin_webrtc 2016/08/24 00:42:20 nit: align

peah-webrtc 2016/08/25 09:25:08 Done.

delegate:self];

videoCallViewController.modalTransitionStyle =

UIModalTransitionStyleCrossDissolve;