Adding AecDump functionality to AppRTCDemo for iOS

webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 12 matching lines @@
   std::unique_ptr<rtc::Thread> _workerThread;
   std::unique_ptr<rtc::Thread> _signalingThread;
 }
 
 @synthesize nativeFactory = _nativeFactory;
 
 - (instancetype)init {
   if ((self = [super init])) {
     _networkThread = rtc::Thread::CreateWithSocketServer();
     BOOL result = _networkThread->Start();
     NSAssert(result, @"Failed to start network thread.");

[tkchin_webrtc, 2016/08/19 17:31:42]

These should probably be updated to return nil if creation fails. Don't have to
do it in this CL though.

[peah-webrtc, 2016/08/23 11:45:15]

Acknowledged.

 
     _workerThread = rtc::Thread::Create();
     result = _workerThread->Start();
     NSAssert(result, @"Failed to start worker thread.");
 
     _signalingThread = rtc::Thread::Create();
     result = _signalingThread->Start();
     NSAssert(result, @"Failed to start signaling thread.");
 
     _nativeFactory = webrtc::CreatePeerConnectionFactory(
         _networkThread.get(), _workerThread.get(), _signalingThread.get(),
         nullptr, nullptr, nullptr);
     NSAssert(_nativeFactory, @"Failed to initialize PeerConnectionFactory!");
   }
   return self;
 }
 
+
+- (BOOL) startAecDump:(NSString *)filename {
+  int fd = open(filename.UTF8String, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
+  if (fd < 0) {
+    NSAssert(_nativeFactory, @"Failed to create the aecdump file!");

[tkchin_webrtc, 2016/08/19 17:31:42]

Why is there an assert on the factory here? Should this just be a log?

[peah-webrtc, 2016/08/23 11:45:15]

That would definitely make sense. I moved this code to ARDAppClient.m and
replaced the assert with a log.

Done.

+    return false;

[tkchin_webrtc, 2016/08/19 17:31:42]

BOOL is YES or NO.

return NO;

[peah-webrtc, 2016/08/23 11:45:15]

Done.

+  }
+
+  // Pass the file to the recorder. The file ownership
+  // is passed to the recorder, and the recorder
+  // closes the file when needed.
+  return _nativeFactory->StartAecDump(fd, -1);
+}
+
+- (void)stopAecDump {
+  // The file is closed by the call below.
+  _nativeFactory->StopAecDump();
+}
+
 - (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:
     (nullable RTCMediaConstraints *)constraints {
   return [[RTCAVFoundationVideoSource alloc] initWithFactory:self
                                                  constraints:constraints];
 }
 
 - (RTCAudioTrack *)audioTrackWithTrackId:(NSString *)trackId {
   return [[RTCAudioTrack alloc] initWithFactory:self
                                         trackId:trackId];
 }
@@ skipping 16 matching lines @@
     (RTCMediaConstraints *)constraints
                                               delegate:
     (nullable id<RTCPeerConnectionDelegate>)delegate {
   return [[RTCPeerConnection alloc] initWithFactory:self
                                       configuration:configuration
                                         constraints:constraints
                                            delegate:delegate];
 }
 
 @end