Issue 2252783003: Expose media constraint string constants as ObjC NSStrings

Issue 2252783003: Expose media constraint string constants as ObjC NSStrings (Closed)

Created:
4 years, 4 months ago by magjed_webrtc

Modified:
4 years, 4 months ago

Reviewers:
tkchin_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Expose media constraint string constants as ObjC NSStrings Committed: https://crrev.com/78810b633c10f408f17c0785d982d4307c839ef0 Cr-Commit-Position: refs/heads/master@{#13801}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	webrtc/sdk/objc/Framework/Classes/RTCMediaConstraints.mm	View		1 chunk	+17 lines, -0 lines	0 comments	Download
	M	webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMediaConstraints.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 9 (4 generated)

tkchin_webrtc

On 2016/08/17 12:11:54, magjed_webrtc wrote: > Zeke - Please take a look. lgtm

4 years, 4 months ago (2016-08-17 17:39:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2252783003/20001

4 years, 4 months ago (2016-08-17 17:56:52 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-08-17 18:07:51 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/78810b633c10f408f17c0785d982d4307c839ef0
Cr-Commit-Position: refs/heads/master@{#13801}