GN: Add "//build/config/sanitizers:deps" to executable targets

webrtc/build/mb_config.pyl

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

[ehmaldonado_webrtc, 2016/08/17 11:32:17]

Changes in this file are not meant to be submitted. They are meant to test
locally the gn bots.
- Ignore goma
- Add gn bots for ubsan

 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # FOR DETAILS ON THIS FILE SEE THE MAIN COPY IN //tools/mb/mb_config.pyl.
 # This is configuration for standalone WebRTC bots. It is used to keep the bot
 # configurations source-side instead of in the buildbot scripts. That makes it
@@ skipping 29 matching lines @@
       'Linux32 ARM': 'gyp_crosscompile_release_bot_arm',
       'Linux32 Debug': 'gyp_debug_bot_x86',
       'Linux32 Release': 'gyp_release_bot_x86',
       'Linux64 Debug': 'gyp_debug_bot_x64',
       'Linux64 Release': 'gyp_release_bot_x64',
       'Linux Asan': 'gyp_asan_lsan_clang_release_bot_x64',
       'Linux Memcheck': 'gyp_memcheck_release_bot_x64',
       'Linux MSan': 'gyp_msan_clang_release_bot_x64',
       'Linux Tsan v2': 'gyp_tsan_clang_release_bot_x64',
       'Linux UBSan': 'gyp_ubsan_clang_release_bot_x64',
+      'Linux UBSan (GN)': 'gn_ubsan_clang_release_bot_x64',

[kjellander_webrtc, 2016/08/17 12:19:22]

This won't change anything if you run this at tryjobs.
To be able to test this properly, you need to change the MB configs for the
trybots, similar to my https://codereview.webrtc.org/2251693002/

[ehmaldonado_webrtc, 2016/08/17 12:37:05]

Oh, I only meant to use mb locally to generate both gn and gyp. These changes
was because presubmit.py was complaining that the configs weren't used.

But that's actually a good idea.

       'Linux UBSan vptr': 'gyp_ubsan_vptr_clang_release_bot_x64',
+      'Linux UBSan vptr (GN)': 'gn_ubsan_vptr_clang_release_bot_x64',
       'Linux64 Release [large tests]': 'gyp_release_bot_x64',
       'Linux64 Debug (GN)': 'gn_debug_bot_x64',
       'Linux64 Release (GN)': 'gn_release_bot_x64',
 
       # Android
       'Android32 Builder': 'android_gyp_release_bot_arm',
       'Android32 Builder (dbg)': 'android_gyp_debug_static_bot_arm',
       'Android32 Builder x86': 'android_gyp_release_bot_x86',
       'Android32 Builder x86 (dbg)': 'android_gyp_debug_static_bot_x86',
       'Android32 Builder MIPS (dbg)': 'android_gyp_clang_debug_static_bot_mipsel',
@@ skipping 160 matching lines @@
     ],
     'gyp_msan_clang_release_bot_x64': [
       'gyp', 'msan', 'clang', 'openh264_release_bot', 'x64'
     ],
     'gyp_tsan_clang_release_bot_x64': [
       'gyp', 'tsan', 'clang', 'openh264_release_bot', 'x64'
     ],
     'gyp_ubsan_clang_release_bot_x64': [
       'gyp', 'ubsan', 'clang', 'openh264_release_bot', 'x64'
     ],
+    'gn_ubsan_clang_release_bot_x64': [
+      'gn', 'ubsan', 'clang', 'openh264_release_bot', 'x64'
+    ],
     'gyp_ubsan_vptr_clang_release_bot_x64': [
       'gyp', 'ubsan_vptr', 'clang', 'openh264_release_bot', 'x64'
     ],
+    'gn_ubsan_vptr_clang_release_bot_x64': [
+      'gn', 'ubsan_vptr', 'clang', 'openh264_release_bot', 'x64'
+    ],
     'gn_debug_bot_x64': [
       'gn', 'openh264_debug_bot', 'x64'
     ],
     'gn_release_bot_x64': [
       'gn', 'openh264_release_bot', 'x64'
     ],
     'swarming_gyp_debug_bot_x64': [
       'swarming', 'gyp', 'openh264_debug_bot', 'x64'
     ],
 
@@ skipping 105 matching lines @@
     'dcheck_always_on': {
       'gn_args': 'dcheck_always_on=true',
       'gyp_defines': 'dcheck_always_on=1',
     },
 
     'debug': {
       'gn_args': 'is_debug=true',
     },
 
     'debug_bot': {
-      'mixins': ['debug', 'shared', 'goma'],
+      'mixins': ['debug', 'shared'],
     },
 
     'debug_static_bot': {
-      'mixins': ['debug', 'static', 'minimal_symbols', 'goma'],
+      'mixins': ['debug', 'static', 'minimal_symbols'],
     },
 
     'device': {
       'gn_args': 'ios_enable_code_signing=false',
       'gyp_defines': 'chromium_ios_signing=0',
     },
 
     'drmemory': {
       'gn_args': 'is_component_build=true enable_iterator_debugging=false',
       'gyp_defines': 'component=shared_library build_for_tool=drmemory',
     },
 
     # This mixin is used to force configs that use it to fail. It
     # is used in two cases: when we have bots that we haven't looked
     # at yet and don't know whether they need MB or not, and for bots
     # that are test-only and should never run MB.
     'error': {
       'gn_args': 'error',
       'gyp_defines': 'target_arch=unknown',
     },
 
     'gn': {'type': 'gn'},
 
-    'goma': {

[kjellander_webrtc, 2016/08/17 12:19:22]

Does Goma change the result or why did you remove it? I'm just curious (I know
you're not intending to submit the mb_config.pyl changes).

[ehmaldonado_webrtc, 2016/08/17 12:37:05]

I don't have goma locally.

[kjellander_webrtc, 2016/08/19 07:56:23]

You should, to speed up compilation. Check out go/ma.

[ehmaldonado_webrtc, 2016/08/19 08:16:06]

Ok, I'll take a look, thanks :)

-      # The MB code will properly escape goma_dir if necessary in the GYP
-      # code path; the GN code path needs no escaping.
-      'gn_args': 'use_goma=true',
-      'gyp_defines': 'use_goma=1',
-    },
-
     'gyp': {'type': 'gyp'},
 
     'ios': {
       'gn_args': 'target_os="ios"',
       'gyp_defines': 'OS=ios',
     },
 
     'ios_debug_bot': {
       'mixins': ['debug', 'shared']
     },
@@ skipping 44 matching lines @@
 
     'openh264_release_bot': {
       'mixins': ['openh264', 'release_bot'],
     },
 
     'release': {
       'gn_args': 'is_debug=false',
     },
 
     'release_bot': {
-      'mixins': ['release', 'static', 'dcheck_always_on', 'goma'],
+      'mixins': ['release', 'static', 'dcheck_always_on'],
     },
 
     'shared': {
       'gn_args': 'is_component_build=true',
       'gyp_defines': 'component=shared_library',
     },
 
     'static': {
       'gn_args': 'is_component_build=false',
       'gyp_defines': 'component=static_library',
@@ skipping 28 matching lines @@
       'gn_args': 'target_cpu="x64"',
       'gyp_defines': 'target_arch=x64',
     },
 
     'x86': {
       'gn_args': 'target_cpu="x86"',
       'gyp_defines': 'target_arch=ia32',
     },
   },
 }