Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2250853002: Add code for dummy file audio to fallback to dummy audio. (Closed)

Created:
4 years, 4 months ago by noahric
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add code for dummy file audio to fallback to dummy audio. BUG= Committed: https://crrev.com/6a35590d14fd8eb3bdfa085095b2362b84338d14 Cr-Commit-Position: refs/heads/master@{#13804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M webrtc/modules/audio_device/audio_device_impl.cc View 1 chunk +7 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device_factory.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
noahric
4 years, 4 months ago (2016-08-16 23:53:19 UTC) #2
kjellander_webrtc
lgtm but henrika probably knows this code better. I see WEBRTC_DUMMY_AUDIO_PLAY_STATIC_FILE doesn't really exist so ...
4 years, 4 months ago (2016-08-17 05:59:39 UTC) #3
noahric
On 2016/08/17 05:59:39, kjellander_webrtc wrote: > lgtm but henrika probably knows this code better. > ...
4 years, 4 months ago (2016-08-17 06:05:39 UTC) #4
henrika_webrtc
How can I say no ;-) LGTM
4 years, 4 months ago (2016-08-17 08:11:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2250853002/1
4 years, 4 months ago (2016-08-17 21:58:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 22:19:53 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 22:20:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a35590d14fd8eb3bdfa085095b2362b84338d14
Cr-Commit-Position: refs/heads/master@{#13804}

Powered by Google App Engine
This is Rietveld 408576698