Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2250683002: WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. (Closed)

Created:
4 years, 4 months ago by ossu
Modified:
4 years, 4 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. Reland of https://codereview.webrtc.org/2072753002/ which broke chromium due to how their build was setup. This issue should now be resolved. Changed WebRtcVoiceEngine to present receive codecs from the formats provided by its decoder factory. Added supported formats to BuiltinAudioDecoderFactory. Added helper functions for creating some simple decoder factories for mocking. Created a PayloadTypeMapper for assigning payload types to formats. I think we'll eventually want to use this further up, or possibly in both the audio and video sides. It would be best if the engines didn't have to talk payload types at all, but it might be more difficult to get around when payload types depend on each-other, like the RTX codecs for video. BUG=webrtc:5805 TBR=ivoc@webrtc.org Committed: https://crrev.com/c54071d8ab695cdc29a7ff1e8e4864c348289033 Cr-Commit-Position: refs/heads/master@{#13793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -32 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/nullwebrtcvideoengine_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/media/engine/payload_type_mapper.h View 1 chunk +39 lines, -1 line 0 comments Download
M webrtc/media/engine/payload_type_mapper.cc View 1 chunk +147 lines, -1 line 0 comments Download
A webrtc/media/engine/payload_type_mapper_unittest.cc View 1 chunk +162 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcmediaengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 6 chunks +70 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 7 chunks +17 lines, -21 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc View 1 chunk +25 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_decoder_factory.h View 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2250683002/1
4 years, 4 months ago (2016-08-17 09:36:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 09:45:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 09:45:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c54071d8ab695cdc29a7ff1e8e4864c348289033
Cr-Commit-Position: refs/heads/master@{#13793}

Powered by Google App Engine
This is Rietveld 408576698