Add a .gyp option to use dummy audio file devices.

Add a gyp/gn option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=

Committed: https://crrev.com/c594aa61bc424f0e22ec84d2682a15b5abb9c1a8
Cr-Commit-Position: refs/heads/master@{#13790}

[noahric, 2016-08-15 21:13:27]

Description was changed from

==========
Add a .gyp option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like win/mac/linux, and
so the conditional slots under include_internal_audio_device, but when enabled,
disables the whatever platform-specific audio layer would have been used.

BUG=
==========

to

==========
Add a .gyp option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=
==========

[noahric, 2016-08-15 21:13:55]

noahric@chromium.org changed reviewers:
+ henrika@chromium.org, kjellander@webrtc.org, phoglund@webrtc.org

[noahric, 2016-08-15 21:13:55]

noahric@chromium.org changed reviewers:
+ henrika@chromium.org, kjellander@webrtc.org, phoglund@webrtc.org

[kjellander_webrtc, 2016-08-16 06:20:05]

Please add GN version as well (declare rtc_use_dummy_audio_file_devices in
webrtc/build/webrtc.gni and then use it in modules/audio_device/BUILD.gn).

https://codereview.webrtc.org/2250483002/diff/1/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/2250483002/diff/1/webrtc/build/common.gypi#newc...
webrtc/build/common.gypi:212: 'use_dummy_audio_file_devices%': 0,
If the default value is going to be the same for Chromium and non-Chromium
builds, please move the declaration of the variable to the section above this
instead (e.g. line 175).

[henrika_webrtc, 2016-08-16 08:39:51]

LGTM % the fact that I have spent very little time on GYP files

[noahric, 2016-08-16 21:02:37]

Added a gn version. Please take a look to make sure it looks right, thanks!

https://codereview.webrtc.org/2250483002/diff/1/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/2250483002/diff/1/webrtc/build/common.gypi#newc...
webrtc/build/common.gypi:212: 'use_dummy_audio_file_devices%': 0,
On 2016/08/16 06:20:05, kjellander_webrtc wrote:
> If the default value is going to be the same for Chromium and non-Chromium
> builds, please move the declaration of the variable to the section above this
> instead (e.g. line 175).

Done. Also added an explanatory comment.

[kjellander_webrtc, 2016-08-16 21:21:52]

lgtm if you update the title and CL description (now includes GN).

I assume no changes were made in the else-clauses (I didn't verify since the
diffs were hard to read).

[noahric, 2016-08-16 22:37:24]

Description was changed from

==========
Add a .gyp option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=
==========

to

==========
Add a gyp/gn option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=
==========

[noahric, 2016-08-16 22:37:56]

On 2016/08/16 21:21:52, kjellander_webrtc wrote:
> lgtm if you update the title and CL description (now includes GN).
> 
> I assume no changes were made in the else-clauses (I didn't verify since the
> diffs were hard to read).

Nothing intentional, just indented to the else clause. Hopefully something in
the trybots would catch it if I messed anything up :-/

[noahric, 2016-08-16 22:52:33]

The CQ bit was checked by noahric@chromium.org

[noahric, 2016-08-16 22:52:34]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2250483002/#ps20001 (title:
"Add gn version")

[commit-bot: I haz the power, 2016-08-16 22:52:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-16 23:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:03:07]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[noahric, 2016-08-16 23:51:02]

The CQ bit was checked by noahric@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:51:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-17 01:21:22]

Description was changed from

==========
Add a gyp/gn option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=
==========

to

==========
Add a gyp/gn option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=
==========

[commit-bot: I haz the power, 2016-08-17 01:21:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 01:21:32]

Description was changed from

==========
Add a gyp/gn option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=
==========

to

==========
Add a gyp/gn option to use dummy audio file devices.

Conceptually, dummy audio file devices are a "platform", like
win/mac/linux, and so the conditional slots under
include_internal_audio_device. When enabled, use_dummy_audio_file_devices
disables whatever platform-specific audio layer would have been used and
turns on dummy file device support.

BUG=

Committed: https://crrev.com/c594aa61bc424f0e22ec84d2682a15b5abb9c1a8
Cr-Commit-Position: refs/heads/master@{#13790}
==========

[commit-bot: I haz the power, 2016-08-17 01:21:33]

Patchset 2 (id:??) landed as
https://crrev.com/c594aa61bc424f0e22ec84d2682a15b5abb9c1a8
Cr-Commit-Position: refs/heads/master@{#13790}