Propagate HAVE_WEBRTC_VIDEO and HAVE_WEBRTC_VIDEO gyp settings.

webrtc/media/engine/webrtcvideoframefactory.h

Index: webrtc/media/engine/webrtcvideoframefactory.h
diff --git a/webrtc/media/engine/webrtcvideoframefactory.h b/webrtc/media/engine/webrtcvideoframefactory.h
index c1569969fb2fb677352755a8fb10eeba8c844b4a..39d813ff75417b6024c985dcac14bed36da77ca3 100644
--- a/webrtc/media/engine/webrtcvideoframefactory.h
+++ b/webrtc/media/engine/webrtcvideoframefactory.h
@@ -20,6 +20,11 @@ struct CapturedFrame;
 // Creates instances of cricket::WebRtcVideoFrame.
 class WebRtcVideoFrameFactory : public VideoFrameFactory {
  public:
+  // Note: Overriding a method name overrides all overloaded versions.
+  // Without this using-declaration, we would hide the 5-argument
+  // method we want to inherit.
+  using VideoFrameFactory::CreateAliasedFrame;

[perkj_webrtc, 2016/08/22 18:00:33]

I don't understand why this suddenly is  a problem and if its related to this
cl? 

Anyhow, you are deprecating VideoFrameFactory right? 

[nisse-webrtc, 2016/08/23 07:09:36]

My guess is that enabling HAVE_WEBRTC_VIDEO when building the tests makes this
code be compiled on android, which it wasn't before. And android is the only
platform where we use gcc, and it seems in this case gcc is stricter than clang
(see compilation errors on the earlier patchset).

I researched a similar issue earlier, and in C++ method lookup is based on
method *name* only, not signature. So the style of the VideoFrameFactory, where
subclasses are encouraged to override only one variant, is not really working.
Adding the using declaration tells the compiler that we want to inherit those
methods with this name which we don't override explicitly.
Yes, I'm aiming at deletion.

+
   VideoFrame* CreateAliasedFrame(const CapturedFrame* aliased_frame,
                                  int width,
                                  int height) const override;