Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2250343002: Fix get_landmines.py script. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix get_landmines.py script. BUG=webrtc:6216 NOTRY=True Committed: https://crrev.com/2ae1fb62f6e132f651ccfdadafbff8a0a4aa43cc Cr-Commit-Position: refs/heads/master@{#13795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
Should I put NOTRY=True?
4 years, 4 months ago (2016-08-17 07:52:04 UTC) #2
kjellander_webrtc
On 2016/08/17 07:52:04, ehmaldonado_webrtc wrote: > Should I put NOTRY=True? Yeah, but fire one trybot ...
4 years, 4 months ago (2016-08-17 07:53:27 UTC) #3
kjellander_webrtc
On 2016/08/17 07:53:27, kjellander_webrtc wrote: > On 2016/08/17 07:52:04, ehmaldonado_webrtc wrote: > > Should I ...
4 years, 4 months ago (2016-08-17 07:55:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2250343002/1
4 years, 4 months ago (2016-08-17 10:52:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 11:00:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 11:00:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ae1fb62f6e132f651ccfdadafbff8a0a4aa43cc
Cr-Commit-Position: refs/heads/master@{#13795}

Powered by Google App Engine
This is Rietveld 408576698