Avoid null pointer exception if Android getCameraInfo fails.

Avoid null pointer exception if Android getCameraInfo fails.

BUG=b/30890971
R=magjed@webrtc.org, sakal@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/7c0f8ee67a4c1f1bb93efd6cfc2f2e32fe6c348c

[AlexG, 2016-08-16 23:53:37]

glaznev@webrtc.org changed reviewers:
+ magjed@webrtc.org

[AlexG, 2016-08-16 23:53:37]

PTAL

[AlexG, 2016-08-16 23:54:27]

The CQ bit was checked by glaznev@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:54:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-17 01:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 01:55:11]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sakal, 2016-08-17 07:35:12]

sakal@webrtc.org changed reviewers:
+ sakal@webrtc.org

[sakal, 2016-08-17 07:35:13]

I would consider removing camera info from the name of the camera completely. I
don't think there is a reason to keep it.

This CL works as a temporary fix though.

lgtm

[magjed_webrtc, 2016-08-17 09:07:32]

On 2016/08/17 07:35:13, sakal wrote:
> I would consider removing camera info from the name of the camera completely.
I
> don't think there is a reason to keep it.
> 
> This CL works as a temporary fix though.
> 
> lgtm

+1. The camera name including camera info is just legacy from when it should be
a "friendly" name. I don't think it matters anymore, and that we can just use
"0" and "1". WebRTC clients can use e.g. isFrontFacing() if they want to find
out information about the camera device.

lgtm regardless if you want to change the camera name in this CL or not.

[AlexG, 2016-08-17 22:16:13]

On 2016/08/17 09:07:32, magjed_webrtc wrote:
> On 2016/08/17 07:35:13, sakal wrote:
> > I would consider removing camera info from the name of the camera
completely.
> I
> > don't think there is a reason to keep it.
> > 
> > This CL works as a temporary fix though.
> > 
> > lgtm
> 
> +1. The camera name including camera info is just legacy from when it should
be
> a "friendly" name. I don't think it matters anymore, and that we can just use
> "0" and "1". WebRTC clients can use e.g. isFrontFacing() if they want to find
> out information about the camera device.
> 
> lgtm regardless if you want to change the camera name in this CL or not.

isFrontFacing will fail if getCameraInfo will return null. So if we just ignore
getCameraInfo()
fails at the time we query camera names we will not be able to correctly detect
front and back
cameras. startCaptureOnCameraThread() will fail too.
It is not clear to me what is better - exclude fail camera from the very
beginning so the app
will not see it or give app and error when it tries to open camera.

[commit-bot: I haz the power, 2016-08-17 22:18:30]

Description was changed from

==========
Avoid null pointer exception if Android getCameraInfo fails.

BUG=b/30890971
==========

to

==========
Avoid null pointer exception if Android getCameraInfo fails.

BUG=b/30890971
R=magjed@webrtc.org, sakal@webrtc.org

Committed: https://crrev.com/7c0f8ee67a4c1f1bb93efd6cfc2f2e32fe6c348c
Cr-Commit-Position: refs/heads/master@{#13803}
==========

[AlexG, 2016-08-17 22:18:30]

Description was changed from

==========
Avoid null pointer exception if Android getCameraInfo fails.

BUG=b/30890971
R=magjed@webrtc.org, sakal@webrtc.org

Committed: https://crrev.com/7c0f8ee67a4c1f1bb93efd6cfc2f2e32fe6c348c
Cr-Commit-Position: refs/heads/master@{#13803}
==========

to

==========
Avoid null pointer exception if Android getCameraInfo fails.

BUG=b/30890971
R=magjed@webrtc.org, sakal@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7c0f8ee67a4c1f1bb93efd6cf...
==========

[commit-bot: I haz the power, 2016-08-17 22:18:31]

Patchset 1 (id:??) landed as
https://crrev.com/7c0f8ee67a4c1f1bb93efd6cfc2f2e32fe6c348c
Cr-Commit-Position: refs/heads/master@{#13803}

[AlexG, 2016-08-17 22:18:31]

Committed patchset #1 (id:1) manually as
7c0f8ee67a4c1f1bb93efd6cfc2f2e32fe6c348c (presubmit successful).