Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2249743007: Disable Intel VP8 HW encoder. (Closed)

Created:
4 years, 4 months ago by AlexG
Modified:
4 years, 4 months ago
Reviewers:
jiayl
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable Intel VP8 HW encoder. Need to investigate dequeueOutputBuffer failure on Asus Zenfones before re-enabling back. BUG=b/30890961 R=jiayl@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/869dab775cf08eb43ac152cb15ecfc5e8a7ba3ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
AlexG
PTAL
4 years, 4 months ago (2016-08-17 21:52:45 UTC) #2
jiayl
lgtm
4 years, 4 months ago (2016-08-17 22:12:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/869dab775cf08eb43ac152cb15ecfc5e8a7ba3ab Cr-Commit-Position: refs/heads/master@{#13805}
4 years, 4 months ago (2016-08-17 22:41:25 UTC) #7
AlexG
Committed patchset #1 (id:1) manually as 869dab775cf08eb43ac152cb15ecfc5e8a7ba3ab (presubmit successful).
4 years, 4 months ago (2016-08-17 22:41:27 UTC) #9
sakal
4 years, 4 months ago (2016-08-18 12:47:34 UTC) #10
Message was sent while issue was closed.
Note: This CL makes framerate on my Zenfone 2 (ZE551ML) really bad. 5 fps on HD,
15 fps on VGA, 27 fps on QVGA. Earlier, I was getting 30 fps on HD (camera
limited).

Powered by Google App Engine
This is Rietveld 408576698