Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2249173002:
iOS: add type to peer connection local streams (Closed)
|
Created:
4 years, 4 months ago by mpotapov Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptioniOS: add type to peer connection local streams
BUG=
Committed: https://crrev.com/96b6b8336a543112573fd91a0cf13a3c1f9d83c9
Cr-Commit-Position: refs/heads/master@{#13825}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix codestyle #
Messages
Total messages: 22 (10 generated)
Description was changed from ========== iOS: add type to peer connection local streams BUG= ========== to ========== iOS: add type to peer connection local streams BUG= ==========
vopatop.skam@gmail.com changed reviewers: + kjellander@google.com, tkchin@chromium.org
vopatop.skam@gmail.com changed reviewers: + kjellander@webrtc.org, tkchin@webrtc.org - kjellander@google.com, tkchin@chromium.org
Hi! This patch allows using `peerConnection.localStreams` items without force upcast in Swift.
Cool, thanks for the patch. https://codereview.webrtc.org/2249173002/diff/1/webrtc/sdk/objc/Framework/Cla... File webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm (right): https://codereview.webrtc.org/2249173002/diff/1/webrtc/sdk/objc/Framework/Cla... webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm:244: - (NSArray<RTCMediaStream*>*)localStreams { nit: - (NSArray<RTCMediaStream *> *)localStreams https://codereview.webrtc.org/2249173002/diff/1/webrtc/sdk/objc/Framework/Hea... File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h (right): https://codereview.webrtc.org/2249173002/diff/1/webrtc/sdk/objc/Framework/Hea... webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h:118: @property(nonatomic, readonly) NSArray<RTCMediaStream*>* localStreams; ditto
The CQ bit was checked by vopatop.skam@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
On 2016/08/18 07:59:37, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-webrtc-committers". > Note that this has nothing to do with OWNERS files. Please upload a new patch set with comments addressed first before commit.
On 2016/08/18 15:31:01, tkchin_webrtc wrote: > On 2016/08/18 07:59:37, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started by full committers or once the patch has > > received an L-G-T-M from a full committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > Committers are members of the group "project-webrtc-committers". > > Note that this has nothing to do with OWNERS files. > > Please upload a new patch set with comments addressed first before commit. Found one more place to fix. Uploaded with new patch set.
On 2016/08/18 18:17:12, zugzug wrote: > On 2016/08/18 15:31:01, tkchin_webrtc wrote: > > On 2016/08/18 07:59:37, commit-bot: I haz the power wrote: > > > No L-G-T-M from a valid reviewer yet. > > > CQ run can only be started by full committers or once the patch has > > > received an L-G-T-M from a full committer. > > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > Committers are members of the group "project-webrtc-committers". > > > Note that this has nothing to do with OWNERS files. > > > > Please upload a new patch set with comments addressed first before commit. > > Found one more place to fix. Uploaded with new patch set. lgtm
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== iOS: add type to peer connection local streams BUG= ========== to ========== iOS: add type to peer connection local streams BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== iOS: add type to peer connection local streams BUG= ========== to ========== iOS: add type to peer connection local streams BUG= Committed: https://crrev.com/96b6b8336a543112573fd91a0cf13a3c1f9d83c9 Cr-Commit-Position: refs/heads/master@{#13825} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/96b6b8336a543112573fd91a0cf13a3c1f9d83c9 Cr-Commit-Position: refs/heads/master@{#13825} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
