Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2249163002: Revert of Adding audio to video_quality_test. (Closed)

Created:
4 years, 4 months ago by minyue-webrtc
Modified:
4 years, 4 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding audio to video_quality_test. (patchset #10 id:230001 of https://codereview.webrtc.org/2136573002/ ) Reason for revert: This CL breaks https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Debug%20(Clang) Need to align values to struct Params {} in a proper way. Relanding will follow. Original issue's description: > Adding audio to video_quality_test. > > This CL adds an audio loopback to video_quality_test (only RunWithVideoRenderer) > > BUG= > > Committed: https://crrev.com/65a6578e339f52eb5bc400c5715e60498e4af2c1 > Cr-Commit-Position: refs/heads/master@{#13784} TBR=stefan@webrtc.org,terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f095012dc207a044ea82ea322cb9600eb66aa500 Cr-Commit-Position: refs/heads/master@{#13785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -163 lines) Patch
M webrtc/video/screenshare_loopback.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/video/video_loopback.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M webrtc/video/video_quality_test.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 6 chunks +12 lines, -144 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
minyue-webrtc
Created Revert of Adding audio to video_quality_test.
4 years, 4 months ago (2016-08-16 15:25:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2249163002/1
4 years, 4 months ago (2016-08-16 15:25:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 15:25:47 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 15:25:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f095012dc207a044ea82ea322cb9600eb66aa500
Cr-Commit-Position: refs/heads/master@{#13785}

Powered by Google App Engine
This is Rietveld 408576698