Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2248883002: Make prior H264 QP adjustments iOS specific. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
Reviewers:
AlexG, pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, peah
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make prior H264 QP adjustments iOS specific. BUG= Committed: https://crrev.com/6c687e72a0013896abf909697e5ca1f5413e1d79 Cr-Commit-Position: refs/heads/master@{#13764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tkchin_webrtc
Puts back the old thresholds for non-iOS.
4 years, 4 months ago (2016-08-15 21:35:23 UTC) #3
pbos-webrtc
rs-lgtm, please try to see if we can agree on values here
4 years, 4 months ago (2016-08-15 21:54:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2248883002/1
4 years, 4 months ago (2016-08-15 22:27:58 UTC) #6
AlexG
lgtm
4 years, 4 months ago (2016-08-15 23:19:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 23:38:00 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 23:38:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c687e72a0013896abf909697e5ca1f5413e1d79
Cr-Commit-Position: refs/heads/master@{#13764}

Powered by Google App Engine
This is Rietveld 408576698