Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2248633003: Disabling the flaky test VolumeTest.ManualRequiresMicrophoneCanSetMicrophoneVolumeWithAgcOff (Closed)

Created:
4 years, 4 months ago by peah-webrtc
Modified:
4 years, 4 months ago
CC:
kjellander_webrtc, webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabling the test VolumeTest.ManualRequiresMicrophoneCanSetMicrophoneVolumeWithAgcOff as it has been found to be flaky. NOTRY=True TBR=henrika@webrtc.org BUG=webrtc:6206 Committed: https://crrev.com/d7d05f80563a3090630d9adc1065315171b3b37f Cr-Commit-Position: refs/heads/master@{#13746}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/voice_engine/test/auto_test/standard/volume_test.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 14 (7 generated)
peah-webrtc
4 years, 4 months ago (2016-08-15 13:03:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2248633003/1
4 years, 4 months ago (2016-08-15 13:04:58 UTC) #6
kjellander_webrtc
https://codereview.webrtc.org/2248633003/diff/1/webrtc/voice_engine/test/auto_test/standard/volume_test.cc File webrtc/voice_engine/test/auto_test/standard/volume_test.cc (right): https://codereview.webrtc.org/2248633003/diff/1/webrtc/voice_engine/test/auto_test/standard/volume_test.cc#newcode176 webrtc/voice_engine/test/auto_test/standard/volume_test.cc:176: TEST_F(VolumeTest, DISABLED_ManualRequiresMicrophoneCanSetMicrophoneVolumeWithAgcOff) { Ideally you add a reference to ...
4 years, 4 months ago (2016-08-15 13:07:15 UTC) #8
peah-webrtc
On 2016/08/15 13:07:15, kjellander_webrtc wrote: > https://codereview.webrtc.org/2248633003/diff/1/webrtc/voice_engine/test/auto_test/standard/volume_test.cc > File webrtc/voice_engine/test/auto_test/standard/volume_test.cc (right): > > https://codereview.webrtc.org/2248633003/diff/1/webrtc/voice_engine/test/auto_test/standard/volume_test.cc#newcode176 > ...
4 years, 4 months ago (2016-08-15 13:09:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 13:13:17 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7d05f80563a3090630d9adc1065315171b3b37f Cr-Commit-Position: refs/heads/master@{#13746}
4 years, 4 months ago (2016-08-15 13:13:24 UTC) #13
henrika_webrtc
4 years, 4 months ago (2016-08-15 13:31:04 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698