Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2248413002: Revert of StartTimestamp generated randomly in RtpSender constructor (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
terelius, åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, mflodman, philipel
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of StartTimestamp generated randomly in RtpSender constructor (patchset #4 id:60001 of https://codereview.webrtc.org/2241193002/ ) Reason for revert: Breaks downstream code. Original issue's description: > StartTimestamp generated randomly in RtpSender constructor > instead of not-randomly at SetSendingState(true) > Renamed to timestamp_offset_ to better match meaning of the variable. > > R=asapersson@webrtc.org, terelius@webrtc.org > > Committed: https://crrev.com/4466782ae43e1b1125a55ee7e18abd10dd37cede > Cr-Commit-Position: refs/heads/master@{#13796} TBR=asapersson@webrtc.org,terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/86c96948e340cf8b879bddb0c7293f3b5ad4dad4 Cr-Commit-Position: refs/heads/master@{#13798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -37 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 8 chunks +27 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
Created Revert of StartTimestamp generated randomly in RtpSender constructor
4 years, 4 months ago (2016-08-17 15:12:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2248413002/1
4 years, 4 months ago (2016-08-17 15:12:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 15:12:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86c96948e340cf8b879bddb0c7293f3b5ad4dad4 Cr-Commit-Position: refs/heads/master@{#13798}
4 years, 4 months ago (2016-08-17 15:12:34 UTC) #6
danilchap
4 years, 4 months ago (2016-08-18 09:01:38 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2257083002/ by danilchap@webrtc.org.

The reason for reverting is: Reland: downstream code expectation about
rtp_sender timestamp adjusted..

Powered by Google App Engine
This is Rietveld 408576698