Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2247943002:
[WebRTC] Disable DirectX capturer tests if the system does not support it. (Closed)
Description[WebRTC] Disable DirectX capturer tests if the system does not support it.
A recent DrMemory failure has been detected after change 2099123002. After some
investigation, an uninitialized read has been detected in
NtUserGetThreadDesktop
webrtc::Desktop::GetThreadDesktop
webrtc::ScopedThreadDesktop::ScopedThreadDesktop
webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi
webrtc::ScreenCapturer::Create
webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody
So there are two issues,
1. The Directx capturer won't be triggered as the system does not support it. So
these tests should be disabled in this scenario.
2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop
stacks, which should be suppressed. By default, these suppressions should be
placed in chromium/external with other suppressions.
So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in
ScreenCaputrerWinDirectx tests.
BUG=
Committed: https://crrev.com/82dda1af5e7401334b819a1b050be19660ace821
Cr-Commit-Position: refs/heads/master@{#13766}
Patch Set 1 #Patch Set 2 : Add log if directx capturer is not supported. #Messages
Total messages: 21 (13 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ========== to ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ==========
zijiehe@chromium.org changed reviewers: + joedow@chromium.org
zijiehe@chromium.org changed reviewers: + sergeyu@chromium.org
Hi, Sergey, This change blocks Dr Memory tests, would you please have a quick look?
Description was changed from ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ========== to ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= TBR=sergeyu@chromium.org, joedow@chromium.org ==========
zijiehe@chromium.org changed reviewers: - joedow@chromium.org, sergeyu@chromium.org
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= TBR=sergeyu@chromium.org, joedow@chromium.org ========== to ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ==========
zijiehe@chromium.org changed reviewers: + joedow@chromium.org, sergeyu@chromium.org
I think the test should create ScreenCapturerDirectx directly to ensure that it always tests the right Screen Capturer implementation. Also this test is useful the way it is even on systems that don't support DirectX, to ensure that the flag is handled correctly. LGTM as a short-term fix to workaround the issue.
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ========== to ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= ========== to ========== [WebRTC] Disable DirectX capturer tests if the system does not support it. A recent DrMemory failure has been detected after change 2099123002. After some investigation, an uninitialized read has been detected in NtUserGetThreadDesktop webrtc::Desktop::GetThreadDesktop webrtc::ScopedThreadDesktop::ScopedThreadDesktop webrtc::ScreenCapturerWinGdi::ScreenCapturerWinGdi webrtc::ScreenCapturer::Create webrtc::ScreenCapturerTest_UseDirectxCapturer_Test::TestBody So there are two issues, 1. The Directx capturer won't be triggered as the system does not support it. So these tests should be disabled in this scenario. 2. An uninitialized read in NtUserGetThreadDesktop -> ScopedThreadDesktop stacks, which should be suppressed. By default, these suppressions should be placed in chromium/external with other suppressions. So this change is a quick fix to the failure, do not use ScreenCapturerWinGdi in ScreenCaputrerWinDirectx tests. BUG= Committed: https://crrev.com/82dda1af5e7401334b819a1b050be19660ace821 Cr-Commit-Position: refs/heads/master@{#13766} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/82dda1af5e7401334b819a1b050be19660ace821 Cr-Commit-Position: refs/heads/master@{#13766} |
