Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 2247293002: GN: Enable msse2 flag in Mac. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Enable msse2 flag in Mac. It was disabled for some reason, even though in GYP it's enabled. BUG=626067 NOTRY=True Committed: https://crrev.com/90920d5bec281c986ff26a53a0599b9c98a1d4cd Cr-Commit-Position: refs/heads/master@{#13780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-16 09:50:56 UTC) #2
kjellander_webrtc
lgtm assuming mac_rel + mac_dbg trybots passes (better run two that actually runs the test ...
4 years, 4 months ago (2016-08-16 10:46:30 UTC) #3
kjellander_webrtc
For the record, it was changed for GYP in https://webrtc-codereview.appspot.com/43169004 but GN was forgotten during ...
4 years, 4 months ago (2016-08-16 11:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2247293002/1
4 years, 4 months ago (2016-08-16 11:05:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 11:13:04 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 11:13:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90920d5bec281c986ff26a53a0599b9c98a1d4cd
Cr-Commit-Position: refs/heads/master@{#13780}

Powered by Google App Engine
This is Rietveld 408576698