Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2247233002: Migrated GN target :isac_fix_test (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, ivoc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target :isac_fix_test Migrated GN target :isac_fix_test from webrtc/modules/audio_coding/codecs/isac/isacfix_test.gypi NOTRY=True BUG=webrtc:6191 Committed: https://crrev.com/b7186d0aa7f9b8af64d714a1011d0d8ee36eb69d Cr-Commit-Position: refs/heads/master@{#13770}

Patch Set 1 : Did not surpress size_t to int truncation error. #

Patch Set 2 : Surpressed win error, added target to .gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M .gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
aleloi
Hi! This is the audio coding test that runs on the bots. It seems straight-forward: ...
4 years, 4 months ago (2016-08-16 07:19:06 UTC) #3
kjellander_webrtc
On 2016/08/16 07:19:06, aleloi wrote: > Hi! This is the audio coding test that runs ...
4 years, 4 months ago (2016-08-16 07:39:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2247233002/20001
4 years, 4 months ago (2016-08-16 08:39:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 08:47:21 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 08:47:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7186d0aa7f9b8af64d714a1011d0d8ee36eb69d
Cr-Commit-Position: refs/heads/master@{#13770}

Powered by Google App Engine
This is Rietveld 408576698