Fixing config for Audio BWE.

Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency should be fixed.

BUG=webrtc:6670
Committed: https://crrev.com/10cbb4648fcd5f4438d5fbb68e086e1d1b02c5c7
Cr-Commit-Position: refs/heads/master@{#14955}

[minyue-webrtc, 2016-08-16 11:21:36]

Description was changed from

==========
fixing default values

BUG=
==========

to

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=
==========

[minyue-webrtc, 2016-08-16 11:21:36]

minyue@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[minyue-webrtc, 2016-08-16 11:23:08]

Hi Magnus,

Please take a look at this CL.

Patch set 1 is a quick fix. But I prefer Patch set 2, which use bps instead kbps
for audio bit rates, which can be clearer.

[mflodman, 2016-08-25 13:45:43]

Thanks for correcting.

Can we quickly discuss if this is the right thing or if we should rather do the
opposite and change the constants to kbps.

[minyue-webrtc, 2016-08-31 15:52:17]

On 2016/08/25 13:45:43, mflodman wrote:
> Thanks for correcting.
> 
> Can we quickly discuss if this is the right thing or if we should rather do
the
> opposite and change the constants to kbps.

I just came back from a holiday and ramping up the work. Let's talk tomorrow.

[mflodman, 2016-09-23 08:05:15]

LG after discussions, you'll need to rebase though and I'll take another look
right after that.

[mflodman, 2016-10-12 00:17:10]

On 2016/09/23 08:05:15, mflodman wrote:
> LG after discussions, you'll need to rebase though and I'll take another look
> right after that.

Ping minyue, shall we get this in?

[minyue-webrtc, 2016-10-28 09:18:00]

On 2016/10/12 00:17:10, mflodman_OOO wrote:
> On 2016/09/23 08:05:15, mflodman wrote:
> > LG after discussions, you'll need to rebase though and I'll take another
look
> > right after that.
> 
> Ping minyue, shall we get this in?

Sorry for delaying this. I just having been stuck by some more challenging
stuff. Now it is rebased, and should be fine to land.

[minyue-webrtc, 2016-11-07 12:28:12]

minyue@webrtc.org changed reviewers:
+ stefan@webrtc.org

[minyue-webrtc, 2016-11-07 12:28:13]

Hi Stefan,

If Magnus is still OOO, would you take a look at this?

[stefan-webrtc, 2016-11-07 12:33:35]

lgtm

https://codereview.webrtc.org/2247213005/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2247213005/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:1362: config_.max_bitrate_bps =
kOpusBitrateFb;
I would suggest adding units to the constants too.

[minyue-webrtc, 2016-11-07 12:46:31]

Description was changed from

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=
==========

to

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=webrtc:6670
==========

[minyue-webrtc, 2016-11-07 13:22:18]

Patchset #5 (id:80001) has been deleted

[minyue-webrtc, 2016-11-07 13:22:37]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-11-07 13:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2247213005/#ps100001 (title:
"on Stefan's suggestion")

[commit-bot: I haz the power, 2016-11-07 13:22:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 15:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 15:51:56]

Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/12816)

[minyue-webrtc, 2016-11-07 15:54:17]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-11-07 15:54:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 17:29:25]

Description was changed from

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=webrtc:6670
==========

to

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=webrtc:6670
==========

[commit-bot: I haz the power, 2016-11-07 17:29:26]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-11-07 17:43:03]

Description was changed from

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=webrtc:6670
==========

to

==========
Fixing config for Audio BWE.

The unit was kbps but the one default use of it is in bps. The inconsistency
should be fixed.

BUG=webrtc:6670

Committed: https://crrev.com/10cbb4648fcd5f4438d5fbb68e086e1d1b02c5c7
Cr-Commit-Position: refs/heads/master@{#14955}
==========

[commit-bot: I haz the power, 2016-11-07 17:43:04]

Patchset 5 (id:??) landed as
https://crrev.com/10cbb4648fcd5f4438d5fbb68e086e1d1b02c5c7
Cr-Commit-Position: refs/heads/master@{#14955}