If encoding is inactive, don't start sending when stream is reconfigured.

If encoding is inactive, don't start sending when stream is reconfigured.

RecreateWebRtcStream was checking the "sending_" flag, but wasn't
checking rtp_parameters_.encodings[0].active. As a result, if an
application calls "RtpSender.setParameters(inactive_params)" then later
the stream is recreated due to some change in SDP parameters, the stream
would incorrectly start sending.

R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/14b9d79bd6b33d753c3215a354be5d94054d4acb

[Taylor Brandstetter, 2016-08-16 00:44:11]

deadbeef@webrtc.org changed reviewers:
+ skvlad@webrtc.org, stefan@webrtc.org

[Taylor Brandstetter, 2016-08-16 00:44:12]

stefan: PTAL. This is something it seems I missed when I first wired up
"RtpEncodingParameters.active"
(https://www.w3.org/TR/webrtc/#dom-rtcrtpencodingparameters-active)

skvlad: CC'ing you because you may have thoughts about this.

[skvlad, 2016-08-17 23:06:08]

lgtm

[Taylor Brandstetter, 2016-08-25 21:40:52]

deadbeef@webrtc.org changed reviewers:
+ mflodman@webrtc.org
- stefan@webrtc.org

[Taylor Brandstetter, 2016-08-25 21:40:52]

Magnus, since Stefan is OOO, can you review or find another appropriate
reviewer? I'm used to pbos reviewing these kinds of changes and don't really
know who the next best owner is.

[pthatcher1, 2016-09-07 21:15:27]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-09-07 21:15:27]

lgtm

[Taylor Brandstetter, 2016-09-07 22:20:31]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-09-07 22:20:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 22:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:27:05]

Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/18066)

[Taylor Brandstetter, 2016-09-07 23:02:42]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-09-07 23:02:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pthatcher@webrtc.org, skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2246313002/#ps20001 (title:
"Making a test assertion better (don't compare pointer addresses).")

[commit-bot: I haz the power, 2016-09-07 23:02:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 23:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:07:16]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/16326)

[commit-bot: I haz the power, 2016-09-08 00:17:02]

Description was changed from

==========
If encoding is inactive, don't start sending when stream is reconfigured.

RecreateWebRtcStream was checking the "sending_" flag, but wasn't
checking rtp_parameters_.encodings[0].active. As a result, if an
application calls "RtpSender.setParameters(inactive_params)" then later
the stream is recreated due to some change in SDP parameters, the stream
would incorrectly start sending.
==========

to

==========
If encoding is inactive, don't start sending when stream is reconfigured.

RecreateWebRtcStream was checking the "sending_" flag, but wasn't
checking rtp_parameters_.encodings[0].active. As a result, if an
application calls "RtpSender.setParameters(inactive_params)" then later
the stream is recreated due to some change in SDP parameters, the stream
would incorrectly start sending.

R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/14b9d79bd6b33d753c3215a354be5d94054d4acb
Cr-Commit-Position: refs/heads/master@{#14116}
==========

[Taylor Brandstetter, 2016-09-08 00:17:03]

Description was changed from

==========
If encoding is inactive, don't start sending when stream is reconfigured.

RecreateWebRtcStream was checking the "sending_" flag, but wasn't
checking rtp_parameters_.encodings[0].active. As a result, if an
application calls "RtpSender.setParameters(inactive_params)" then later
the stream is recreated due to some change in SDP parameters, the stream
would incorrectly start sending.

R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/14b9d79bd6b33d753c3215a354be5d94054d4acb
Cr-Commit-Position: refs/heads/master@{#14116}
==========

to

==========
If encoding is inactive, don't start sending when stream is reconfigured.

RecreateWebRtcStream was checking the "sending_" flag, but wasn't
checking rtp_parameters_.encodings[0].active. As a result, if an
application calls "RtpSender.setParameters(inactive_params)" then later
the stream is recreated due to some change in SDP parameters, the stream
would incorrectly start sending.

R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/14b9d79bd6b33d753c3215a35...
==========

[commit-bot: I haz the power, 2016-09-08 00:17:03]

Patchset 2 (id:??) landed as
https://crrev.com/14b9d79bd6b33d753c3215a354be5d94054d4acb
Cr-Commit-Position: refs/heads/master@{#14116}

[Taylor Brandstetter, 2016-09-08 00:17:04]

Committed patchset #2 (id:20001) manually as
14b9d79bd6b33d753c3215a354be5d94054d4acb (presubmit successful).