Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 2245393003: MB: Fix incorrect iOS builder names. (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Fix incorrect iOS builder names. In https://codereview.webrtc.org/2239643002/ MB was turned on for the iOS GYP bots. This exposed an incorrect config for the iOS simulator bots in client.webrtc. BUG=589510 NOTRY=True Committed: https://crrev.com/e252d3ce3a3a14a554296f9caabc46fa9b4a2c1f Cr-Commit-Position: refs/heads/master@{#13778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/build/mb_config.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 4 months ago (2016-08-16 10:40:34 UTC) #2
ehmaldonado_webrtc
On 2016/08/16 10:40:34, kjellander_webrtc wrote: lgtm
4 years, 4 months ago (2016-08-16 10:43:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2245393003/1
4 years, 4 months ago (2016-08-16 10:45:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 10:46:24 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 10:46:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e252d3ce3a3a14a554296f9caabc46fa9b4a2c1f
Cr-Commit-Position: refs/heads/master@{#13778}

Powered by Google App Engine
This is Rietveld 408576698