Added ProbeBitrate(bitrate_bps, num_probes) to BitrateProber.

webrtc/modules/pacing/bitrate_prober.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_PACING_BITRATE_PROBER_H_
 #define WEBRTC_MODULES_PACING_BITRATE_PROBER_H_
 
-#include <cstddef>
-#include <list>
-#include <queue>
+#include <deque>
 
 #include "webrtc/typedefs.h"
 
 namespace webrtc {
 
 // Note that this class isn't thread-safe by itself and therefore relies
 // on being protected by the caller.
 class BitrateProber {
  public:
   BitrateProber();
 
   void SetEnabled(bool enable);

[danilchap, 2016/08/12 15:13:34]

Is this function still in use?
Seems dangerous to keep it around since it's behaviour silently changed: it no
longer works without new ProbeBitrate function.

 
   // Returns true if the prober is in a probing session, i.e., it currently
   // wants packets to be sent out according to the time returned by
   // TimeUntilNextProbe().
   bool IsProbing() const;
 
   // Initializes a new probing session if the prober is allowed to probe. Does
   // not initialize the prober unless the packet size is large enough to probe
   // with.
-  void OnIncomingPacket(uint32_t bitrate_bps,
-                        size_t packet_size,
-                        int64_t now_ms);
+  void OnIncomingPacket(size_t packet_size);
+
+  // Create a cluster used to probe for |bitrate_bps| with |num_packets| number
+  // of packets.
+  void ProbeBitrate(uint32_t bitrate_bps, int num_packets);

[stefan-webrtc, 2016/08/12 13:19:59]

ProbeAtBitrate or CreateProbeAtBitrate?

[philipel, 2016/08/12 14:08:07]

Change to ProbeAtBitrate.

 
   // Returns the number of milliseconds until the next packet should be sent to
   // get accurate probing.
   int TimeUntilNextProbe(int64_t now_ms);
 
   // Which cluster that is currently being used for probing.
   int CurrentClusterId() const;
 
   // Returns the number of bytes that the prober recommends for the next probe
   // packet.
@@ skipping 24 matching lines @@
     int id = -1;
   };
 
   // Resets the state of the prober and clears any cluster/timing data tracked.
   void ResetState();
 
   ProbingState probing_state_;
   // Probe bitrate per packet. These are used to compute the delta relative to
   // the previous probe packet based on the size and time when that packet was
   // sent.
-  std::queue<ProbeCluster> clusters_;
+  std::deque<ProbeCluster> clusters_;
   size_t packet_size_last_sent_;
   // The last time a probe was sent.
   int64_t time_last_probe_sent_ms_;
   int next_cluster_id_;
 };
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_PACING_BITRATE_PROBER_H_