NetEq: Changing checked_cast to saturated_cast

NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.

Committed: https://crrev.com/38d840c35a85996b9b50294becc2239e8123f67e
Cr-Commit-Position: refs/heads/master@{#13815}

[hlundin-webrtc, 2016-08-18 08:48:37]

Description was changed from

==========
NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.
==========

to

==========
NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.
==========

[hlundin-webrtc, 2016-08-18 08:48:37]

henrik.lundin@webrtc.org changed reviewers:
+ aleloi@webrtc.org

[hlundin-webrtc, 2016-08-18 08:48:59]

Alex, PTAL.

Thanks!

[aleloi, 2016-08-18 08:59:02]

Just to check that I understood all the template code in saturated_cast
correctly: 

saturated_cast<int>(int64 value) checks that the incoming value is inside the
range of an int. If it is not, it returns the minimal or maximal value of the
destination type. 'int' in this case.

If it's not more complicated than that, then it LGTM!

[hlundin-webrtc, 2016-08-18 09:02:56]

On 2016/08/18 08:59:02, aleloi wrote:
> Just to check that I understood all the template code in saturated_cast
> correctly: 
> 
> saturated_cast<int>(int64 value) checks that the incoming value is inside the
> range of an int. If it is not, it returns the minimal or maximal value of the
> destination type. 'int' in this case.
> 
> If it's not more complicated than that, then it LGTM!

That is my understanding, too.

[hlundin-webrtc, 2016-08-18 09:03:04]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-08-18 09:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-18 10:49:36]

Description was changed from

==========
NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.
==========

to

==========
NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.
==========

[commit-bot: I haz the power, 2016-08-18 10:49:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 10:49:47]

Description was changed from

==========
NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.
==========

to

==========
NetEq: Changing checked_cast to saturated_cast

The cast involves packet_len_samp, which is derived from the timestamps
and sequence numbers of incoming packets. Being values from the outside,
these should be treated as if any value is possible, making a
checked_cast unsuitable. Changing instead to saturated_cast to avoid
overflow with out-of-bounds values.

Committed: https://crrev.com/38d840c35a85996b9b50294becc2239e8123f67e
Cr-Commit-Position: refs/heads/master@{#13815}
==========

[commit-bot: I haz the power, 2016-08-18 10:49:48]

Patchset 1 (id:??) landed as
https://crrev.com/38d840c35a85996b9b50294becc2239e8123f67e
Cr-Commit-Position: refs/heads/master@{#13815}