RTCCertificateStats added.

webrtc/api/rtcstatscollector.h

Index: webrtc/api/rtcstatscollector.h
diff --git a/webrtc/api/rtcstatscollector.h b/webrtc/api/rtcstatscollector.h
index 61edc52d0d2a89ff8c2b2fd27a391abc85c17625..0eaba37d39771bc5d7959c54767bd5cec19acf2d 100644
--- a/webrtc/api/rtcstatscollector.h
+++ b/webrtc/api/rtcstatscollector.h
@@ -21,9 +21,16 @@
 #include "webrtc/base/scoped_ref_ptr.h"
 #include "webrtc/base/timeutils.h"
 
+namespace rtc {
+
+class SSLCertificate;
+
+}  // namespace rtc
+
 namespace webrtc {
 
 class PeerConnection;
+struct SessionStats;
 
 class RTCStatsCollectorCallback : public virtual rtc::RefCountInterface {
  public:
@@ -69,8 +76,14 @@ class RTCStatsCollector : public virtual rtc::RefCountInterface {
   void AddPartialResults_s(rtc::scoped_refptr<RTCStatsReport> partial_report);
   void DeliverCachedReport();
 
-  std::unique_ptr<RTCPeerConnectionStats> ProducePeerConnectionStats_s(
-      int64_t timestamp_us) const;
+  void ProduceCertificateStats_s(

[hta-webrtc, 2016/09/29 13:22:58]

Why the _s suffix? (here and elsewhere)

[hbos, 2016/10/03 12:11:59]

_s for stuff to be executed on the signaling thread, _w for worker thread and _n
for network thread.
So far everything is on the signaling thread, but with some refactoring of
classes used to get the stats I think we can spread the work and avoid several
synchronous thread Invokes (lower priority than adding stats atm).

+      RTCStatsReport* report, int64_t timestamp_us,
+      const SessionStats& session_stats) const;

[hta-webrtc, 2016/09/29 13:22:58]

Order of arguments: First inputs, then outputs.

https://google.github.io/styleguide/cppguide.html#Function_Parameter_Ordering

[hbos, 2016/10/03 12:11:59]

Done.

+  void ProduceCertificateStatsFromSSLCertificateAndChain_s(
+      RTCStatsReport* report, int64_t timestamp_us,
+      const rtc::SSLCertificate* certificate) const;
+  void ProducePeerConnectionStats_s(
+      RTCStatsReport* report, int64_t timestamp_us) const;
 
   PeerConnection* const pc_;
   rtc::Thread* const signaling_thread_;