Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2241293002: GN: Fix audio_decoder_unittests for android. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix audio_decoder_unittests for android. Tested on a physical device. BUG=webrtc:6036 NOTRY=True Committed: https://crrev.com/b1e66110e3b41b8913bd4d7cd9c50de30fc8a5d7 Cr-Commit-Position: refs/heads/master@{#13761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-15 15:57:26 UTC) #2
kjellander_webrtc
lgtm. For WebRTC bugs, you have to prefix the number with webrtc: in order to ...
4 years, 4 months ago (2016-08-15 16:11:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2241293002/1
4 years, 4 months ago (2016-08-15 18:53:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 19:02:06 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 19:02:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1e66110e3b41b8913bd4d7cd9c50de30fc8a5d7
Cr-Commit-Position: refs/heads/master@{#13761}

Powered by Google App Engine
This is Rietveld 408576698