Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2241243002: Revert of Added new mixer to |check_targets| in .gn and fixed include/depend errors. (Closed)

Created:
4 years, 4 months ago by olka_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@mixer_dir_structure_comments
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added new mixer to |check_targets| in .gn and fixed include/depend errors. (patchset #1 id:1 of https://codereview.webrtc.org/2234293002/ ) Reason for revert: Breaks Chromium FYI builds, for example https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/9219/steps/compile/logs/stdio Original issue's description: > Added new mixer to |check_targets| in .gn and fixed include/depend errors. > > Also fixed one small chromium-style error in the new mixer. > > NOTRY=True > > Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9 > Cr-Commit-Position: refs/heads/master@{#13752} TBR=kjellander@webrtc.org,aleloi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2ab1da7c37cae7836bb2e59a5d90aed0f998d73a Cr-Commit-Position: refs/heads/master@{#13753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M .gn View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
olka_webrtc
Created Revert of Added new mixer to |check_targets| in .gn and fixed include/depend errors.
4 years, 4 months ago (2016-08-15 14:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2241243002/1
4 years, 4 months ago (2016-08-15 14:36:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 14:36:21 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 14:36:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ab1da7c37cae7836bb2e59a5d90aed0f998d73a
Cr-Commit-Position: refs/heads/master@{#13753}

Powered by Google App Engine
This is Rietveld 408576698