webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc - Issue 2241193002: StartTimestamp generated randomly in RtpSender constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

Issue 2241193002: StartTimestamp generated randomly in RtpSender constructor (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Renames start_timestamp->timestamp_offset in RtcpSender Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

index 270088ebac7938f79a950e393efbdb69adc1d698..5d230dc6f1bc18b92a912bc12bd15d94229f81d9 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

@@ -243,7 +243,7 @@ class RtcpSenderTest : public ::testing::Test {

nullptr, nullptr, &test_transport_));

rtcp_sender_->SetSSRC(kSenderSsrc);

rtcp_sender_->SetRemoteSSRC(kRemoteSsrc);

- rtcp_sender_->SetStartTimestamp(kStartRtpTimestamp);

+ rtcp_sender_->SetTimestampOffset(kStartRtpTimestamp);

rtcp_sender_->SetLastRtpTime(kRtpTimestamp, clock_.TimeInMilliseconds());

}

@@ -813,7 +813,7 @@ TEST_F(RtcpSenderTest, ByeMustBeLast) {

nullptr, nullptr, &mock_transport));

rtcp_sender_->SetSSRC(kSenderSsrc);

rtcp_sender_->SetRemoteSSRC(kRemoteSsrc);

- rtcp_sender_->SetStartTimestamp(kStartRtpTimestamp);

+ rtcp_sender_->SetTimestampOffset(kStartRtpTimestamp);

rtcp_sender_->SetLastRtpTime(kRtpTimestamp, clock_.TimeInMilliseconds());

// Set up XR VoIP metric to be included with BYE

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc » ('j') | no next file with comments »