RTCStats and RTCStatsReport added (webrtc/stats)

webrtc/stats/BUILD.gn

+# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS.  All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
+
+import("../build/webrtc.gni")
+import("//testing/test.gni")
+
+# GYP version: webrtc/stats/stats.gyp:rtc_stats
+source_set("rtc_stats") {
+  cflags = []
+  sources = [
+    "rtcstats.cc",
+    "rtcstatsreport.cc",
+  ]
+
+  configs += [ "..:common_config" ]
+  public_configs = [ "..:common_inherited_config" ]
+
+  if (is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    configs -= [ "//build/config/clang:find_bad_constructs" ]

[kjellander_webrtc, 2016/08/15 11:21:51]

Can't you fix the warnings instead of having to add this?

[hbos, 2016/08/15 13:27:11]

Done.

[kjellander_webrtc, 2016/08/15 13:34:20]

If you fixed the warnings, remove this line to prove it's sufficient :)
Same below.

[hbos, 2016/08/15 13:57:57]

Done. (Oops, lost removing those lines when switching PC.)

+  }
+
+  deps = [
+    "../api:libjingle_peerconnection",
+  ]
+}
+
+if (rtc_include_tests) {
+  # GYP version: webrtc/stats/stats.gyp:rtc_stats_unittests
+  test("rtc_stats_unittests") {

[hbos, 2016/08/13 08:31:39]

This is a new unittest built from a new folder, webrtc/stats/. I assume bots
don't run it? Is a new binary OK? Do we enable it on bots before or after this
CL has landed?

[kjellander_webrtc, 2016/08/15 11:21:51]

Can you make this target run on Android as well? 

Then it needs
if (is_android) {
  deps += [ "//testing/android/native_test:native_test_native_code" ]
}

[hbos, 2016/08/15 13:27:12]

Done.

[hbos, 2016/08/15 13:57:57]

I made it work for GN, but not GYP as discussed offline (removed GYP's
dependency).

+    testonly = true
+    sources = [
+      "rtcstats_unittest.cc",
+    ]
+
+    configs += [ "..:common_config" ]
+    public_configs = [ "..:common_inherited_config" ]
+
+    if (is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+      configs -= [ "//build/config/clang:find_bad_constructs" ]

[kjellander_webrtc, 2016/08/15 11:21:51]

Please fix the warnings instead of adding this (unless they're a flood of
warnings that comes from dependencies, making it unfeasible to do in this CL).

[hbos, 2016/08/15 13:27:11]

Done.

+    }
+
+    deps = [
+      ":rtc_stats",
+      "../base:rtc_base_tests_utils",
+      "../system_wrappers:metrics_default",
+      "//testing/gmock",
+    ]
+  }
+}