Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2240763002:
Removed the deactivation of the level controller when there is a built-in AGC available (Closed)
|
Created:
4 years, 4 months ago by peah-webrtc Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemoved the deactivation of the level controller when there is a built-in AGC available
BUG=
Committed: https://crrev.com/72a5645fdf94507a1fd7b662200657ddc4de3a8c
Cr-Commit-Position: refs/heads/master@{#13853}
Patch Set 1 #
Messages
Total messages: 29 (17 generated)
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/9494)
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/9495) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/9497)
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org, tina.legrand@webrtc.org
Notera att BultInAGCIsAvailable anropet enligt Qualcomm inte är korrekt för Android och att det för Android i princip alltid returnerar false, och för iOS alltid returnerar true.
Note that BultInAGCIsAvailable for iOS always return true, and for Android in principle always returns false.
On 2016/08/12 22:01:04, peah-webrtc wrote: > Note that BultInAGCIsAvailable for iOS always return true, and for Android in > principle always returns false. LGTM, but please verify performance on iOS before committing.
Description was changed from ========== Removed the deactivation of the level controller when there is a built-in AGC available BUG= ========== to ========== Removed the deactivation of the level controller when there is a built-in AGC available BUG= ==========
peah@webrtc.org changed reviewers: + mflodman@webrtc.org
+mflodman@ as an OWNER of webrtc/media/
peah@webrtc.org changed reviewers: + solenberg@webrtc.org - mflodman@webrtc.org
lgtm
lgtm
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Removed the deactivation of the level controller when there is a built-in AGC available BUG= ========== to ========== Removed the deactivation of the level controller when there is a built-in AGC available BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Removed the deactivation of the level controller when there is a built-in AGC available BUG= ========== to ========== Removed the deactivation of the level controller when there is a built-in AGC available BUG= Committed: https://crrev.com/72a5645fdf94507a1fd7b662200657ddc4de3a8c Cr-Commit-Position: refs/heads/master@{#13853} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/72a5645fdf94507a1fd7b662200657ddc4de3a8c Cr-Commit-Position: refs/heads/master@{#13853} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
