Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2239423002: Change the default backup connection ping interval to 25 seconds. (Closed)

Created:
4 years, 4 months ago by honghaiz3
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change the default backup connection ping interval to 25 seconds. This avoids the issue that the backup connection may be pinged faster than the stable rate (once every 2.5 second) we have chosen for non-backup connections. R=deadbeef@webrtc.org, pthatcher@webrtc.org, zhihuang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/895e1a9dc3f520e9d86b1fa8b0808a4fd34d01fa

Patch Set 1 #

Patch Set 2 : Change the default to 25 seconds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/p2p/base/p2ptransportchannel.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
honghaiz3
4 years, 4 months ago (2016-08-12 17:19:13 UTC) #2
honghaiz3
Changed the default to 25 seconds.
4 years, 4 months ago (2016-08-15 21:11:23 UTC) #3
Taylor Brandstetter
lgtm
4 years, 4 months ago (2016-08-15 22:19:01 UTC) #5
Zhi Huang
lgtm
4 years, 4 months ago (2016-08-16 03:03:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2239423002/20001
4 years, 4 months ago (2016-08-16 16:41:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-16 18:41:55 UTC) #10
pthatcher1
lgtm
4 years, 4 months ago (2016-08-16 20:48:16 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/895e1a9dc3f520e9d86b1fa8b0808a4fd34d01fa Cr-Commit-Position: refs/heads/master@{#13787}
4 years, 4 months ago (2016-08-16 23:48:20 UTC) #14
honghaiz3
4 years, 4 months ago (2016-08-16 23:48:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
895e1a9dc3f520e9d86b1fa8b0808a4fd34d01fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698