Moving mock classes around so that they may be reused in other unittests

Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
Committed: https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723
Cr-Commit-Position: refs/heads/master@{#13769}

[hbos, 2016-08-11 13:31:58]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 13:32:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-08-11 13:35:36]

Description was changed from

==========
Moving mock classes around so that they may be reused in other unittests

BUG=chromium:627816
==========

to

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/mockpeerconnection.h
+webrtc/api/mockwebrtcsession.h
+webrtc/media/base/test/mockmediachannel.h

BUG=chromium:627816
==========

[hbos, 2016-08-11 13:40:47]

hbos@webrtc.org changed reviewers:
+ kjellander@webrtc.org, pthatcher@webrtc.org

[hbos, 2016-08-11 13:40:48]

Please take a look pthatcher and kjellander.

Just moving out some Mock classes into their own header files so that they can
be reused. I'll want to use the mocks for the new stats collector CL I'm working
on.

[hbos, 2016-08-11 13:42:34]

Description was changed from

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/mockpeerconnection.h
+webrtc/api/mockwebrtcsession.h
+webrtc/media/base/test/mockmediachannel.h

BUG=chromium:627816
==========

to

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/mockpeerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/mockwebrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mockmediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

BUG=chromium:627816
==========

[hbos, 2016-08-12 09:16:00]

Description was changed from

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/mockpeerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/mockwebrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mockmediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

BUG=chromium:627816
==========

to

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mockpeerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mockwebrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mockmediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
==========

[magjed_webrtc, 2016-08-12 09:51:29]

magjed@webrtc.org changed reviewers:
+ magjed@webrtc.org

[magjed_webrtc, 2016-08-12 09:54:54]

webrtc/media/ lgtm

[hbos, 2016-08-12 12:13:48]

hbos@webrtc.org changed reviewers:
+ tommi@webrtc.org
- pthatcher@webrtc.org

[hbos, 2016-08-12 12:13:49]

Please take a look tommi (pthatcher being OOO, replacing with magjed+tommi) and
please take a look kjellander.

[kjellander_webrtc, 2016-08-15 07:06:43]

On 2016/08/12 12:13:49, hbos wrote:
> Please take a look tommi (pthatcher being OOO, replacing with magjed+tommi)
and
> please take a look kjellander.

LGTM but I'm personally favoring using '_' in filenames. The style guide
https://google.github.io/styleguide/cppguide.html#File_Names says:
Filenames should be all lowercase and can include underscores (_) or dashes (-).
Follow the convention that your project uses. If there is no consistent local
pattern to follow, prefer "_".

And if I do 
$ git ls-files | grep mock
all our similar mock headers in the project is using '_' separators with
webrtc/api/test/mockpeerconnectionobservers.h being the only exception. 
I guess we should probably do all that in for webrtc/api in a separate CL
though.

[hbos, 2016-08-15 10:42:31]

hbos@webrtc.org changed reviewers:
+ perkj@webrtc.org

[hbos, 2016-08-15 10:42:31]

perkj can you take a look and stamp this? (tommi is OOO for webrtc/api)

[perkj_webrtc, 2016-08-16 07:22:17]

lgtm

[hbos, 2016-08-16 07:58:32]

Description was changed from

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mockpeerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mockwebrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mockmediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
==========

to

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
==========

[hbos, 2016-08-16 07:58:49]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-08-16 07:58:49]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2238933002/#ps40001 (title:
"Underscore in filenames")

[commit-bot: I haz the power, 2016-08-16 07:58:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-16 08:19:46]

Description was changed from

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
==========

to

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
==========

[commit-bot: I haz the power, 2016-08-16 08:19:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-16 08:19:55]

Description was changed from

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816
==========

to

==========
Moving mock classes around so that they may be reused in other unittests

New files, classes moved from statscollector_unittest.cc:
+webrtc/api/test/mock_peerconnection.h
 for MockPeerConnectionFactory and MockPeerConnection
+webrtc/api/test/mock_webrtcsession.h
 for MockWebRtcSession
+webrtc/media/base/test/mock_mediachannel.h
 for MockVideoMediaChannel and MockVoiceMediaChannel

The webrtc/media/base/test folder is new.

BUG=chromium:627816

Committed: https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723
Cr-Commit-Position: refs/heads/master@{#13769}
==========

[commit-bot: I haz the power, 2016-08-16 08:19:56]

Patchset 3 (id:??) landed as
https://crrev.com/b24b1ceb480455d6cac1f907eb5bd1afbb402723
Cr-Commit-Position: refs/heads/master@{#13769}

[hbos, 2016-08-18 08:14:36]

+CC nisse: FYI, a TODO of yours was moved from statscollector_unittest.cc to
mock_webrtcsession.h.