Changed folder structure in new mixer and fixed simple lint errors.

Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.

NOTRY=True

Committed: https://crrev.com/5bcc00e538203bb6714e6a6537b87ca1dfd7e8f3
Cr-Commit-Position: refs/heads/master@{#13742}

[aleloi, 2016-08-11 07:43:30]

Patchset #2 (id:20001) has been deleted

[aleloi, 2016-08-11 07:49:54]

aleloi@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[aleloi, 2016-08-11 07:49:55]

Hi! This one should be rather straight-forward. It's an update of the new mixer
to the new directory structure that was agreed upon in the 'Slim and Modular
WebRTC' discussions. source/ and include/ are gone, but test/ is left.

I also did a little improvement that should have been done when I copied the
mixer in the beginning: audio_frame_operations.(h|cc) are copied over from the
old audio_conference_mixer, formatted and fixed for lint errors. If we had 'gn
check' in place, it would have spotted this as a missing dependency.

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/BU...
File webrtc/modules/audio_mixer/BUILD.gn (right):

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/BU...
webrtc/modules/audio_mixer/BUILD.gn:53: "new_audio_conference_mixer_impl.h",
The audio_frame_manipulator dependency was previously just imported from
modules/audio_conference_mixer/source. This did not produce a compiler error,
because every executable that depended on the new mixer (a few tests) also
depended on the old one.

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/au...
File webrtc/modules/audio_mixer/audio_frame_manipulator.cc (right):

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/au...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:62: }  // namespace webrtc
This is copied from modules/audio_conference_mixer/source. I updated the
variable names, function names and calling signatures. If I upload a new patch
set, I'll tune down the '--similarity' argument so it recognizes this as a copy.

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/au...
File webrtc/modules/audio_mixer/audio_frame_manipulator.h (right):

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/au...
webrtc/modules/audio_mixer/audio_frame_manipulator.h:24: void
NewMixerRampOut(AudioFrame* audio_frame);
Prefixed with 'NewMixer' to avoid name clash. Changed args from non-const ref to
pointer to fix lint error.

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/in...
File webrtc/modules/audio_mixer/include/audio_mixer_defines.h (left):

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/in...
webrtc/modules/audio_mixer/include/audio_mixer_defines.h:1: /*
File copied one directory up. (Hit 'k')

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/in...
File webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h (left):

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/in...
webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h:1: /*
Same for this one.

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/te...
File webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc (right):

https://codereview.webrtc.org/2238803002/diff/1/webrtc/modules/audio_mixer/te...
webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc:458: constexpr int
kNumParticipants = 20;
This was detected by the linter. Strange that it didn't come up earlier.

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
File webrtc/modules/audio_mixer/audio_frame_manipulator.cc (right):

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:1: /*
With 10% similarity, it thought this to be a copy of something unrelated. With
35% it thinks it's a new file. Actually it's a copy of
webrtc/modules/audio_conference_mixer/source/audio_frame_manipulator.cc.
Probably it thinks the diff is too large after 'git cl format' has been run.

[hlundin-webrtc, 2016-08-12 13:14:31]

lgtm with a few nits.

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
File webrtc/modules/audio_mixer/audio_frame_manipulator.cc (right):

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:1: /*
On 2016/08/11 07:49:55, aleloi wrote:
> With 10% similarity, it thought this to be a copy of something unrelated. With
> 35% it thinks it's a new file. Actually it's a copy of
> webrtc/modules/audio_conference_mixer/source/audio_frame_manipulator.cc.
> Probably it thinks the diff is too large after 'git cl format' has been run.

Acknowledged.

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:15: namespace {
I'm not sure it matters, but we tend to have the unnamed namespace within the
webrtc namespace.

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:18: const float
rampArray[] = {
Wrong naming format for rampArray.

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:29: const size_t rampSize
= sizeof(rampArray) / sizeof(rampArray[0]);
... and for rampSize.

https://codereview.webrtc.org/2238803002/diff/40001/webrtc/modules/audio_mixe...
webrtc/modules/audio_mixer/audio_frame_manipulator.cc:54: const size_t rampPos =
rampSize - 1 - i;
Wrong naming format for rampPos.

[aleloi, 2016-08-15 09:50:04]

Fixed the nits. Uploading!

[aleloi, 2016-08-15 09:50:08]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-08-15 09:50:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2238803002/#ps60001 (title:
"Small changes in response to comments.")

[commit-bot: I haz the power, 2016-08-15 09:50:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2016-08-15 09:58:59]

Description was changed from

==========
Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.
==========

to

==========
Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-15 10:01:34]

Description was changed from

==========
Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.

NOTRY=True
==========

to

==========
Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-15 10:01:35]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-15 10:01:43]

Description was changed from

==========
Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.

NOTRY=True
==========

to

==========
Changed folder structure in new mixer and fixed simple lint errors.

The folder structure is now as was agreed on in the 'Slim and Modular
WebRTC' effort.  Also added some dependencies that were previously in
another part of the tree.

NOTRY=True

Committed: https://crrev.com/5bcc00e538203bb6714e6a6537b87ca1dfd7e8f3
Cr-Commit-Position: refs/heads/master@{#13742}
==========

[commit-bot: I haz the power, 2016-08-15 10:01:44]

Patchset 3 (id:??) landed as
https://crrev.com/5bcc00e538203bb6714e6a6537b87ca1dfd7e8f3
Cr-Commit-Position: refs/heads/master@{#13742}