FakeTiming added, an implementation of Timing that can be used for tests

FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE

Committed: https://crrev.com/8f956dead64b3b9f635b021ea58453a089cf5d9e
Cr-Commit-Position: refs/heads/master@{#13750}

[hbos, 2016-08-12 14:15:24]

Description was changed from

==========
FakeTiming added, an implementation of Timing that can be used for tests

I intend to use this in another CL.

BUG=chromium:627816
==========

to

==========
FakeTiming added, an implementation of Timing that can be used for tests.

Note: The webrtc/base/test/ folder is new. Other test classes should be moved
here?

I intend to use this in another CL.

BUG=chromium:627816
==========

[hbos, 2016-08-12 14:17:28]

Description was changed from

==========
FakeTiming added, an implementation of Timing that can be used for tests.

Note: The webrtc/base/test/ folder is new. Other test classes should be moved
here?

I intend to use this in another CL.

BUG=chromium:627816
==========

to

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
==========

[hbos, 2016-08-12 14:20:24]

hbos@webrtc.org changed reviewers:
+ hta@webrtc.org, kjellander@webrtc.org

[hbos, 2016-08-12 14:20:24]

Please take a look, kjellander and hta.

I created the webrtc/base/test/, is this right kjellander? Also, is there a bug
I should reference? I guess we should move other fake and mock classes of
webrtc/base/ into webrtc/base/test/?

[hta - Chromium, 2016-08-13 06:16:37]

hta@chromium.org changed reviewers:
+ hta@chromium.org

[hta - Chromium, 2016-08-13 06:16:38]

lgtm

Using a common utility class for time injection seems good to me. Kjellander
will have to say if it's in the right place.

(I assume you're writing new classes that have injectable time.)

https://codereview.webrtc.org/2238073003/diff/1/webrtc/base/test/faketiming.h
File webrtc/base/test/faketiming.h (right):

https://codereview.webrtc.org/2238073003/diff/1/webrtc/base/test/faketiming.h...
webrtc/base/test/faketiming.h:21: FakeTiming() : now_(0.0) {}
A matter of style: Can you make this class start at some date other than Jan 1,
1970? This will make it easy to spot errors caused by reading zero instead of
the intended time.

For reasons of nostalgia, I would suggest Jan 1, 1983 (the Internet Flag Day,
when the old Arpanet protocol support was turned off and the TCP/IP based
Internet was made mandatory for the Arpanet).

[hbos, 2016-08-13 07:24:37]

hta, you LGTM'd with your @chromium, you'll have to stamp with your @webrtc.

Please take a look, kjellander.

https://codereview.webrtc.org/2238073003/diff/1/webrtc/base/test/faketiming.h
File webrtc/base/test/faketiming.h (right):

https://codereview.webrtc.org/2238073003/diff/1/webrtc/base/test/faketiming.h...
webrtc/base/test/faketiming.h:21: FakeTiming() : now_(0.0) {}
On 2016/08/13 06:16:38, hta - Chromium wrote:
> A matter of style: Can you make this class start at some date other than Jan
1,
> 1970? This will make it easy to spot errors caused by reading zero instead of
> the intended time.
> 
> For reasons of nostalgia, I would suggest Jan 1, 1983 (the Internet Flag Day,
> when the old Arpanet protocol support was turned off and the TCP/IP based
> Internet was made mandatory for the Arpanet).
> 

Done. :) Those were the days.

[kjellander_webrtc, 2016-08-15 11:29:08]

lgtm

[hbos, 2016-08-15 11:42:13]

Description was changed from

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
==========

to

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=True
==========

[hbos, 2016-08-15 11:42:45]

Landing with NOPRESUBMIT=True because hta LGTM'd with chromium instead of webrtc
account.

[hbos, 2016-08-15 11:42:49]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-08-15 11:42:49]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@chromium.org
Link to the patchset: https://codereview.webrtc.org/2238073003/#ps20001 (title:
"Changed starting time")

[commit-bot: I haz the power, 2016-08-15 11:42:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 13:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 13:43:26]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hbos, 2016-08-15 13:59:42]

Description was changed from

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=True
==========

to

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE
==========

[hbos, 2016-08-15 13:59:49]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-08-15 13:59:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 14:00:01]

Description was changed from

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE
==========

to

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE
==========

[commit-bot: I haz the power, 2016-08-15 14:00:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-15 14:00:10]

Description was changed from

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE
==========

to

==========
FakeTiming added, an implementation of Timing that can be used for
tests.

Note: The webrtc/base/test/ folder is new.

Currently not used, I intend to use this in another CL.

BUG=chromium:627816
NOPRESUBMIT=TRUE
NOTRY=TRUE

Committed: https://crrev.com/8f956dead64b3b9f635b021ea58453a089cf5d9e
Cr-Commit-Position: refs/heads/master@{#13750}
==========

[commit-bot: I haz the power, 2016-08-15 14:00:11]

Patchset 2 (id:??) landed as
https://crrev.com/8f956dead64b3b9f635b021ea58453a089cf5d9e
Cr-Commit-Position: refs/heads/master@{#13750}