Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2236923002: Make variable for selecting if intervals without samples should be included in stats configurable (… (Closed)

Created:
4 years, 4 months ago by åsapersson
Modified:
4 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make variable for selecting if intervals without samples should be included in stats configurable (for rate counters). BUG= Committed: https://crrev.com/5093b38497d5d0032db15245b4e1683f5ab1319e Cr-Commit-Position: refs/heads/master@{#13740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M webrtc/video/stats_counter.h View 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/video/stats_counter.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/video/stats_counter_unittest.cc View 4 chunks +31 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
åsapersson
4 years, 4 months ago (2016-08-11 15:16:46 UTC) #3
stefan-webrtc
lgtm
4 years, 4 months ago (2016-08-13 10:07:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2236923002/1
4 years, 4 months ago (2016-08-15 06:49:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/9544)
4 years, 4 months ago (2016-08-15 06:52:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2236923002/1
4 years, 4 months ago (2016-08-15 08:12:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 08:20:33 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 08:20:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5093b38497d5d0032db15245b4e1683f5ab1319e
Cr-Commit-Position: refs/heads/master@{#13740}

Powered by Google App Engine
This is Rietveld 408576698