Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2236323002: Convert PeerConnectionTest to use the new capture APIs. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Convert PeerConnectionTest to use the new capture APIs. Committed: https://crrev.com/9591e3e82dd9d0e67d4f8fff3883bc044a29bff7 Cr-Commit-Position: refs/heads/master@{#13735}

Patch Set 1 #

Patch Set 2 : Call stop capture for safety. #

Patch Set 3 : Don't capture to texture to preserve the original behavior. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java View 1 2 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sakal
Magnus, PTAL.
4 years, 4 months ago (2016-08-11 11:09:26 UTC) #2
magjed_webrtc
lgtm
4 years, 4 months ago (2016-08-11 12:58:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2236323002/40001
4 years, 4 months ago (2016-08-11 13:00:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-11 15:01:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2236323002/40001
4 years, 4 months ago (2016-08-12 06:58:33 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 07:06:18 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 07:06:29 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9591e3e82dd9d0e67d4f8fff3883bc044a29bff7
Cr-Commit-Position: refs/heads/master@{#13735}

Powered by Google App Engine
This is Rietveld 408576698